Re: [PATCH next] sched: remove NET_XMIT_POLICED

2016-06-11 Thread Florian Westphal
David Miller wrote: > I have to revert this, the sch_atm.c change is wrong. > > NET_XMIT_POLICED is the default value of 'ret' which can be used > if we branch to 'drop'. So now GCC says that 'ret' might be used > uninitialized. Hmpf, seems I need to update gcc :-| > So it is actually used, an

Re: [PATCH next] sched: remove NET_XMIT_POLICED

2016-06-11 Thread David Miller
From: David Miller Date: Fri, 10 Jun 2016 23:31:37 -0700 (PDT) > From: Florian Westphal > Date: Fri, 10 Jun 2016 14:21:29 +0200 > >> ... its not returned anywhere. >> >> BATMAN uses it as an intermediate return value to signal >> forwarding vs. buffering, but it will not return POLICED to >> c

Re: [PATCH next] sched: remove NET_XMIT_POLICED

2016-06-10 Thread David Miller
From: Florian Westphal Date: Fri, 10 Jun 2016 14:21:29 +0200 > ... its not returned anywhere. > > BATMAN uses it as an intermediate return value to signal > forwarding vs. buffering, but it will not return POLICED to > callers outside of BATMAN. > > sch_atm uses it, but on closer look its not r

Re: [PATCH next] sched: remove NET_XMIT_POLICED

2016-06-10 Thread Sven Eckelmann
On Friday 10 June 2016 14:21:29 Florian Westphal wrote: [...] > BATMAN uses it as an intermediate return value to signal > forwarding vs. buffering, but it will not return POLICED to > callers outside of BATMAN. [...] > diff --git a/net/batman-adv/send.c b/net/batman-adv/send.c > index f2f1256..b1a

Re: [PATCH next] sched: remove NET_XMIT_POLICED

2016-06-10 Thread Eric Dumazet
On Fri, 2016-06-10 at 14:21 +0200, Florian Westphal wrote: > ... its not returned anywhere. > > BATMAN uses it as an intermediate return value to signal > forwarding vs. buffering, but it will not return POLICED to > callers outside of BATMAN. > > sch_atm uses it, but on closer look its not retur

[PATCH next] sched: remove NET_XMIT_POLICED

2016-06-10 Thread Florian Westphal
... its not returned anywhere. BATMAN uses it as an intermediate return value to signal forwarding vs. buffering, but it will not return POLICED to callers outside of BATMAN. sch_atm uses it, but on closer look its not returned either since the initialisation is always overwritten with qdisc_enqu