Re: [PATCH net v5 3/6] ipv4: Dump route exceptions if requested

2019-06-19 Thread Stefano Brivio
On Tue, 18 Jun 2019 08:48:23 -0600 David Ahern wrote: > > +++ b/net/ipv4/fib_trie.c > > @@ -2000,28 +2000,92 @@ void fib_free_table(struct fib_table *tb) > > call_rcu(&tb->rcu, __trie_free_rcu); > > } > > > > +static int fib_dump_fnhe_from_leaf(struct fib_alias *fa, struct sk_buff > > *sk

Re: [PATCH net v5 3/6] ipv4: Dump route exceptions if requested

2019-06-18 Thread David Ahern
On 6/18/19 7:20 AM, Stefano Brivio wrote: > diff --git a/include/net/route.h b/include/net/route.h > index 065b47754f05..f0d0086e76ce 100644 > --- a/include/net/route.h > +++ b/include/net/route.h > @@ -221,6 +221,9 @@ void ip_rt_get_source(u8 *src, struct sk_buff *skb, > struct rtable *rt); > st

[PATCH net v5 3/6] ipv4: Dump route exceptions if requested

2019-06-18 Thread Stefano Brivio
Since commit 4895c771c7f0 ("ipv4: Add FIB nexthop exceptions."), cached exception routes are stored as a separate entity, so they are not dumped on a FIB dump, even if the RTM_F_CLONED flag is passed. This implies that the command 'ip route list cache' doesn't return any result anymore. If the RT