Re: [PATCH net v3 0/2] ipv6: Fix listing and flushing of cached route exceptions

2019-06-11 Thread David Ahern
On 6/11/19 2:19 PM, Martin Lau wrote: > On Tue, Jun 11, 2019 at 12:47:58AM +0200, Stefano Brivio wrote: >> On Mon, 10 Jun 2019 23:53:15 +0200 >> Stefano Brivio wrote: >> >>> On Mon, 10 Jun 2019 15:38:06 -0600 >>> David Ahern wrote: >>> in dot releases of stable trees, I think it would be bet

Re: [PATCH net v3 0/2] ipv6: Fix listing and flushing of cached route exceptions

2019-06-11 Thread Martin Lau
On Tue, Jun 11, 2019 at 12:47:58AM +0200, Stefano Brivio wrote: > On Mon, 10 Jun 2019 23:53:15 +0200 > Stefano Brivio wrote: > > > On Mon, 10 Jun 2019 15:38:06 -0600 > > David Ahern wrote: > > > > > in dot releases of stable trees, I think it would be better to converge > > > on consistent beha

Re: [PATCH net v3 0/2] ipv6: Fix listing and flushing of cached route exceptions

2019-06-10 Thread Stefano Brivio
On Mon, 10 Jun 2019 23:53:15 +0200 Stefano Brivio wrote: > On Mon, 10 Jun 2019 15:38:06 -0600 > David Ahern wrote: > > > in dot releases of stable trees, I think it would be better to converge > > on consistent behavior between v4 and v6. By that I mean without the > > CLONED flag, no exception

Re: [PATCH net v3 0/2] ipv6: Fix listing and flushing of cached route exceptions

2019-06-10 Thread Stefano Brivio
On Mon, 10 Jun 2019 15:38:06 -0600 David Ahern wrote: > On 6/8/19 12:12 PM, Stefano Brivio wrote: > > The commands 'ip -6 route list cache' and 'ip -6 route flush cache' > > don't work at all after route exceptions have been moved to a separate > > hash table in commit 2b760fcf5cfb ("ipv6: hook u

Re: [PATCH net v3 0/2] ipv6: Fix listing and flushing of cached route exceptions

2019-06-10 Thread Martin Lau
On Mon, Jun 10, 2019 at 03:38:06PM -0600, David Ahern wrote: > The ability to list exceptions was deleted 2 years ago with 4.15. So far > no one has complained that exceptions do not show up in route dumps. > Rather than perturb the system again and worse with different behaviors, > in dot releases

Re: [PATCH net v3 0/2] ipv6: Fix listing and flushing of cached route exceptions

2019-06-10 Thread David Ahern
On 6/8/19 12:12 PM, Stefano Brivio wrote: > The commands 'ip -6 route list cache' and 'ip -6 route flush cache' > don't work at all after route exceptions have been moved to a separate > hash table in commit 2b760fcf5cfb ("ipv6: hook up exception table to store > dst cache"). Fix that. The breakag

[PATCH net v3 0/2] ipv6: Fix listing and flushing of cached route exceptions

2019-06-08 Thread Stefano Brivio
The commands 'ip -6 route list cache' and 'ip -6 route flush cache' don't work at all after route exceptions have been moved to a separate hash table in commit 2b760fcf5cfb ("ipv6: hook up exception table to store dst cache"). Fix that. v3: Drop check on RTM_F_CLONED and rework logic of return val