Re: [PATCH net v3] net: sched: do not requeue a NULL skb

2016-04-13 Thread David Miller
From: Lars Persson Date: Tue, 12 Apr 2016 08:45:52 +0200 > A failure in validate_xmit_skb_list() triggered an unconditional call > to dev_requeue_skb with skb=NULL. This slowly grows the queue > discipline's qlen count until all traffic through the queue stops. > > We take the optimistic approac

Re: [PATCH net v3] net: sched: do not requeue a NULL skb

2016-04-12 Thread Eric Dumazet
On Tue, 2016-04-12 at 08:45 +0200, Lars Persson wrote: > A failure in validate_xmit_skb_list() triggered an unconditional call > to dev_requeue_skb with skb=NULL. This slowly grows the queue > discipline's qlen count until all traffic through the queue stops. > > Fixes: 55a93b3ea780 ("qdisc: vali

[PATCH net v3] net: sched: do not requeue a NULL skb

2016-04-11 Thread Lars Persson
A failure in validate_xmit_skb_list() triggered an unconditional call to dev_requeue_skb with skb=NULL. This slowly grows the queue discipline's qlen count until all traffic through the queue stops. We take the optimistic approach and continue running the queue after a failure since it is unknown