Re: [PATCH net v3] net: fix pos incrementment in ipv6_route_seq_next

2020-10-15 Thread Jakub Kicinski
On Wed, 14 Oct 2020 07:46:12 -0700 Yonghong Song wrote: > Commit 4fc427e05158 ("ipv6_route_seq_next should increase position index") > tried to fix the issue where seq_file pos is not increased > if a NULL element is returned with seq_ops->next(). See bug > https://bugzilla.kernel.org/show_bug.cg

Re: [PATCH net v3] net: fix pos incrementment in ipv6_route_seq_next

2020-10-14 Thread Andrii Nakryiko
On Wed, Oct 14, 2020 at 2:53 PM Yonghong Song wrote: > > Commit 4fc427e05158 ("ipv6_route_seq_next should increase position index") > tried to fix the issue where seq_file pos is not increased > if a NULL element is returned with seq_ops->next(). See bug > https://bugzilla.kernel.org/show_bug.cg

Re: [PATCH net v3] net: fix pos incrementment in ipv6_route_seq_next

2020-10-14 Thread Yonghong Song
On 10/14/20 4:14 PM, Andrii Nakryiko wrote: On Wed, Oct 14, 2020 at 2:53 PM Yonghong Song wrote: Commit 4fc427e05158 ("ipv6_route_seq_next should increase position index") tried to fix the issue where seq_file pos is not increased if a NULL element is returned with seq_ops->next(). See bug

Re: [PATCH net v3] net: fix pos incrementment in ipv6_route_seq_next

2020-10-14 Thread Martin KaFai Lau
On Wed, Oct 14, 2020 at 07:46:12AM -0700, Yonghong Song wrote: > Commit 4fc427e05158 ("ipv6_route_seq_next should increase position index") > tried to fix the issue where seq_file pos is not increased > if a NULL element is returned with seq_ops->next(). See bug > https://bugzilla.kernel.org/show

[PATCH net v3] net: fix pos incrementment in ipv6_route_seq_next

2020-10-14 Thread Yonghong Song
Commit 4fc427e05158 ("ipv6_route_seq_next should increase position index") tried to fix the issue where seq_file pos is not increased if a NULL element is returned with seq_ops->next(). See bug https://bugzilla.kernel.org/show_bug.cgi?id=206283 The commit effectively does: - increase pos for al