Re: [PATCH net v3] ibmvnic: fix ibmvnic_set_mac

2020-10-29 Thread Jakub Kicinski
On Tue, 27 Oct 2020 17:04:56 -0500 Lijun Pan wrote: > Jakub Kicinski brought up a concern in ibmvnic_set_mac(). > ibmvnic_set_mac() does this: > > ether_addr_copy(adapter->mac_addr, addr->sa_data); > if (adapter->state != VNIC_PROBED) > rc = __ibmvnic_set_mac(netdev, addr

[PATCH net v3] ibmvnic: fix ibmvnic_set_mac

2020-10-27 Thread Lijun Pan
Jakub Kicinski brought up a concern in ibmvnic_set_mac(). ibmvnic_set_mac() does this: ether_addr_copy(adapter->mac_addr, addr->sa_data); if (adapter->state != VNIC_PROBED) rc = __ibmvnic_set_mac(netdev, addr->sa_data); So if state == VNIC_PROBED, the user can assi