irussk...@marvell.com;
> gust...@embeddedor.com; magnus.karls...@intel.com;
> ec...@solarflare.com; Ido Schimmel ; Jiri Pirko
> ; mlxsw
> Subject: Re: [PATCH net v2 1/2] ethtool: Add link_mode parameter capability
> bit to ethtool_ops
>
> > @@ -436,12 +436,16 @@ int __eth
> @@ -436,12 +436,16 @@ int __ethtool_get_link_ksettings(struct net_device *dev,
>
> memset(link_ksettings, 0, sizeof(*link_ksettings));
>
> - link_ksettings->link_mode = -1;
> err = dev->ethtool_ops->get_link_ksettings(dev, link_ksettings);
> if (err)
> retu
> First, it is not the API structure that is passed to user space. Please pay
> attention
Yes, sorry. Jumped to assumptions without checking.
Let me try again.
Andrew
irussk...@marvell.com;
> gust...@embeddedor.com; magnus.karls...@intel.com;
> ec...@solarflare.com; Ido Schimmel ; Jiri Pirko
> ; mlxsw
> Subject: Re: [PATCH net v2 1/2] ethtool: Add link_mode parameter capability
> bit to ethtool_ops
>
> On Sun, Apr 04, 2021 at 11:14:32AM +030
On Sun, Apr 04, 2021 at 11:14:32AM +0300, Danielle Ratson wrote:
> Some drivers clear the 'ethtool_link_ksettings' struct in their
> get_link_ksettings() callback, before populating it with actual values.
> Such drivers will set the new 'link_mode' field to zero, resulting in
> user space receiving
Some drivers clear the 'ethtool_link_ksettings' struct in their
get_link_ksettings() callback, before populating it with actual values.
Such drivers will set the new 'link_mode' field to zero, resulting in
user space receiving wrong link mode information given that zero is a
valid value for the fie
