Le 14/05/2019 à 12:24, Sabrina Dubroca a écrit :
[snip]
> Yes, that's possible although quite unlikely. I'll go with d8a5ec672768.
>
Agreed.
Thank you,
Nicolas
2019-05-14, 12:05:16 +0200, Nicolas Dichtel wrote:
> Le 14/05/2019 à 10:01, Sabrina Dubroca a écrit :
> > 2019-05-14, 09:32:32 +0200, Nicolas Dichtel wrote:
> [snip]
> >> What about this one?
> >> Fixes: d8a5ec672768 ("[NET]: netlink support for moving devices between
> >> network
> >> namespaces.
Le 14/05/2019 à 10:01, Sabrina Dubroca a écrit :
> 2019-05-14, 09:32:32 +0200, Nicolas Dichtel wrote:
[snip]
>> What about this one?
>> Fixes: d8a5ec672768 ("[NET]: netlink support for moving devices between
>> network
>> namespaces.")
>
> Nice. Now I think the bug can't really trigger unless one
2019-05-14, 09:32:32 +0200, Nicolas Dichtel wrote:
> Le 13/05/2019 à 23:46, Sabrina Dubroca a écrit :
> > 2019-05-13, 17:13:36 +0200, Nicolas Dichtel wrote:
> >> Le 13/05/2019 à 17:08, Sabrina Dubroca a écrit :
> >>> 2019-05-13, 16:50:51 +0200, Nicolas Dichtel wrote:
> Le 13/05/2019 à 15:47, S
Le 13/05/2019 à 23:46, Sabrina Dubroca a écrit :
> 2019-05-13, 17:13:36 +0200, Nicolas Dichtel wrote:
>> Le 13/05/2019 à 17:08, Sabrina Dubroca a écrit :
>>> 2019-05-13, 16:50:51 +0200, Nicolas Dichtel wrote:
Le 13/05/2019 à 15:47, Sabrina Dubroca a écrit :
> Currently, nla_put_iflink() do
2019-05-13, 17:13:36 +0200, Nicolas Dichtel wrote:
> Le 13/05/2019 à 17:08, Sabrina Dubroca a écrit :
> > 2019-05-13, 16:50:51 +0200, Nicolas Dichtel wrote:
> >> Le 13/05/2019 à 15:47, Sabrina Dubroca a écrit :
> >>> Currently, nla_put_iflink() doesn't put the IFLA_LINK attribute when
> >>> iflink
IFLA_LINK is typoed in subject line, you might want to fix that if respinning.
-Ed
On 5/13/19 9:18 AM, Nicolas Dichtel wrote:
> Adding this attribute may change the output of 'ip link'.
> See this patch for example:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=95ec655bc465
>
>
I figured that would be the response, but wanted to make sure.
On Mon, 13 May 2019 17:18:28 +0200
Nicolas Dichtel wrote:
> Le 13/05/2019 à 17:07, David Ahern a écrit :
> > On 5/13/19 7:47 AM, Sabrina Dubroca wrote:
> >> Currently, nla_put_iflink() doesn't put the IFLA_LINK attribute when
> >> iflink == ifindex.
> >>
> >> In some cases, a device can be crea
From: Nicolas Dichtel
Date: Mon, 13 May 2019 16:50:51 +0200
> Le 13/05/2019 à 15:47, Sabrina Dubroca a écrit :
>> Currently, nla_put_iflink() doesn't put the IFLA_LINK attribute when
>> iflink == ifindex.
>>
>> In some cases, a device can be created in a different netns with the
>> same ifindex
Le 13/05/2019 à 17:07, David Ahern a écrit :
> On 5/13/19 7:47 AM, Sabrina Dubroca wrote:
>> Currently, nla_put_iflink() doesn't put the IFLA_LINK attribute when
>> iflink == ifindex.
>>
>> In some cases, a device can be created in a different netns with the
>> same ifindex as its parent. That devi
Le 13/05/2019 à 17:08, Sabrina Dubroca a écrit :
> 2019-05-13, 16:50:51 +0200, Nicolas Dichtel wrote:
>> Le 13/05/2019 à 15:47, Sabrina Dubroca a écrit :
>>> Currently, nla_put_iflink() doesn't put the IFLA_LINK attribute when
>>> iflink == ifindex.
>>>
>>> In some cases, a device can be created in
2019-05-13, 16:50:51 +0200, Nicolas Dichtel wrote:
> Le 13/05/2019 à 15:47, Sabrina Dubroca a écrit :
> > Currently, nla_put_iflink() doesn't put the IFLA_LINK attribute when
> > iflink == ifindex.
> >
> > In some cases, a device can be created in a different netns with the
> > same ifindex as its
On 5/13/19 7:47 AM, Sabrina Dubroca wrote:
> Currently, nla_put_iflink() doesn't put the IFLA_LINK attribute when
> iflink == ifindex.
>
> In some cases, a device can be created in a different netns with the
> same ifindex as its parent. That device will not dump its IFLA_LINK
> attribute, which c
Le 13/05/2019 à 15:47, Sabrina Dubroca a écrit :
> Currently, nla_put_iflink() doesn't put the IFLA_LINK attribute when
> iflink == ifindex.
>
> In some cases, a device can be created in a different netns with the
> same ifindex as its parent. That device will not dump its IFLA_LINK
> attribute, w
Currently, nla_put_iflink() doesn't put the IFLA_LINK attribute when
iflink == ifindex.
In some cases, a device can be created in a different netns with the
same ifindex as its parent. That device will not dump its IFLA_LINK
attribute, which can confuse some userspace software that expects it.
For
16 matches
Mail list logo
