Re: [PATCH net v2] netfilter: nat: cope with negative port range

2018-02-14 Thread Pablo Neira Ayuso
On Wed, Feb 14, 2018 at 04:45:31PM +0100, Paolo Abeni wrote: > Hi, > > On Wed, 2018-02-14 at 14:51 +0100, Pablo Neira Ayuso wrote: > > On Wed, Feb 14, 2018 at 01:30:37PM +0100, Florian Westphal wrote: > > > Eric Dumazet wrote: > > > > On Wed, 2018-02-14 at 12:13 +0100, Paolo Abeni wrote: > > > >

Re: [PATCH net v2] netfilter: nat: cope with negative port range

2018-02-14 Thread Paolo Abeni
Hi, On Wed, 2018-02-14 at 14:51 +0100, Pablo Neira Ayuso wrote: > On Wed, Feb 14, 2018 at 01:30:37PM +0100, Florian Westphal wrote: > > Eric Dumazet wrote: > > > On Wed, 2018-02-14 at 12:13 +0100, Paolo Abeni wrote: > > > > syzbot reported a division by 0 bug in the netfilter nat code: > > > > Ad

Re: [PATCH net v2] netfilter: nat: cope with negative port range

2018-02-14 Thread Pablo Neira Ayuso
On Wed, Feb 14, 2018 at 01:30:37PM +0100, Florian Westphal wrote: > Eric Dumazet wrote: > > On Wed, 2018-02-14 at 12:13 +0100, Paolo Abeni wrote: > > > syzbot reported a division by 0 bug in the netfilter nat code: > > > > > Adding the relevant check at parse time could break existing > > > setup

Re: [PATCH net v2] netfilter: nat: cope with negative port range

2018-02-14 Thread Eric Dumazet
On Wed, 2018-02-14 at 13:30 +0100, Florian Westphal wrote: > Eric Dumazet wrote: > > On Wed, 2018-02-14 at 12:13 +0100, Paolo Abeni wrote: > > > syzbot reported a division by 0 bug in the netfilter nat code: > > > Adding the relevant check at parse time could break existing > > > setup, moreover w

Re: [PATCH net v2] netfilter: nat: cope with negative port range

2018-02-14 Thread Florian Westphal
Eric Dumazet wrote: > On Wed, 2018-02-14 at 12:13 +0100, Paolo Abeni wrote: > > syzbot reported a division by 0 bug in the netfilter nat code: > > > Adding the relevant check at parse time could break existing > > setup, moreover we would need to read/write such values atomically > > to avoid pos

Re: [PATCH net v2] netfilter: nat: cope with negative port range

2018-02-14 Thread Eric Dumazet
On Wed, 2018-02-14 at 12:13 +0100, Paolo Abeni wrote: > syzbot reported a division by 0 bug in the netfilter nat code: ... > Adding the relevant check at parse time could break existing > setup, moreover we would need to read/write such values atomically > to avoid possible transient negative ran

[PATCH net v2] netfilter: nat: cope with negative port range

2018-02-14 Thread Paolo Abeni
syzbot reported a division by 0 bug in the netfilter nat code: divide error: [#1] SMP KASAN Dumping ftrace buffer: (ftrace buffer empty) Modules linked in: CPU: 1 PID: 4168 Comm: syzkaller034710 Not tainted 4.16.0-rc1+ #309 Hardware name: Google Google Compute Engine/Google Compute Engine