Re: [PATCH net v2] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-15 Thread Eelco Chaudron
On 15 Oct 2020, at 14:34, Sebastian Andrzej Siewior wrote: On 2020-10-15 11:46:53 [+0200], Eelco Chaudron wrote: The flow_lookup() function uses per CPU variables, which must not be preempted. However, this is fine in the general napi use case where the local BH is disabled. But, it's also c

Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-15 Thread Eelco Chaudron
On 15 Oct 2020, at 13:22, Ilya Maximets wrote: On 10/15/20 1:04 PM, Ilya Maximets wrote: On 10/15/20 12:54 PM, Eelco Chaudron wrote: On 15 Oct 2020, at 12:27, Ilya Maximets wrote: On 10/15/20 11:46 AM, Eelco Chaudron wrote: The flow_lookup() function uses per CPU variables, which must n

Re: [PATCH net v2] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-15 Thread Sebastian Andrzej Siewior
On 2020-10-15 11:46:53 [+0200], Eelco Chaudron wrote: > The flow_lookup() function uses per CPU variables, which must not be > preempted. However, this is fine in the general napi use case where > the local BH is disabled. But, it's also called in the netlink > context, which is preemptible. The be

Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-15 Thread Ilya Maximets
On 10/15/20 1:04 PM, Ilya Maximets wrote: > On 10/15/20 12:54 PM, Eelco Chaudron wrote: >> >> >> On 15 Oct 2020, at 12:27, Ilya Maximets wrote: >> >>> On 10/15/20 11:46 AM, Eelco Chaudron wrote: The flow_lookup() function uses per CPU variables, which must not be preempted. However, this

Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-15 Thread Ilya Maximets
On 10/15/20 12:54 PM, Eelco Chaudron wrote: > > > On 15 Oct 2020, at 12:27, Ilya Maximets wrote: > >> On 10/15/20 11:46 AM, Eelco Chaudron wrote: >>> The flow_lookup() function uses per CPU variables, which must not be >>> preempted. However, this is fine in the general napi use case where >>> t

Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-15 Thread Eelco Chaudron
On 15 Oct 2020, at 12:27, Ilya Maximets wrote: On 10/15/20 11:46 AM, Eelco Chaudron wrote: The flow_lookup() function uses per CPU variables, which must not be preempted. However, this is fine in the general napi use case where the local BH is disabled. But, it's also called in the netlink c

Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-15 Thread Ilya Maximets
On 10/15/20 11:46 AM, Eelco Chaudron wrote: > The flow_lookup() function uses per CPU variables, which must not be > preempted. However, this is fine in the general napi use case where > the local BH is disabled. But, it's also called in the netlink > context, which is preemptible. The below patch

[PATCH net v2] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-15 Thread Eelco Chaudron
The flow_lookup() function uses per CPU variables, which must not be preempted. However, this is fine in the general napi use case where the local BH is disabled. But, it's also called in the netlink context, which is preemptible. The below patch makes sure that even in the netlink path, preemption