Re: [PATCH net v2] net: don't keep lonely packets forever in the gro hash

2018-11-23 Thread David Miller
From: Paolo Abeni Date: Wed, 21 Nov 2018 18:21:35 +0100 > Eric noted that with UDP GRO and NAPI timeout, we could keep a single > UDP packet inside the GRO hash forever, if the related NAPI instance > calls napi_gro_complete() at an higher frequency than the NAPI timeout. > Willem noted that even

Re: [PATCH net v2] net: don't keep lonely packets forever in the gro hash

2018-11-21 Thread Eric Dumazet
On 11/21/2018 09:21 AM, Paolo Abeni wrote: > Eric noted that with UDP GRO and NAPI timeout, we could keep a single > UDP packet inside the GRO hash forever, if the related NAPI instance > calls napi_gro_complete() at an higher frequency than the NAPI timeout. Acked-by: Eric Dumazet

Re: [PATCH net v2] net: don't keep lonely packets forever in the gro hash

2018-11-21 Thread Willem de Bruijn
On Wed, Nov 21, 2018 at 12:21 PM Paolo Abeni wrote: > > Eric noted that with UDP GRO and NAPI timeout, we could keep a single > UDP packet inside the GRO hash forever, if the related NAPI instance > calls napi_gro_complete() at an higher frequency than the NAPI timeout. > Willem noted that even TC

[PATCH net v2] net: don't keep lonely packets forever in the gro hash

2018-11-21 Thread Paolo Abeni
Eric noted that with UDP GRO and NAPI timeout, we could keep a single UDP packet inside the GRO hash forever, if the related NAPI instance calls napi_gro_complete() at an higher frequency than the NAPI timeout. Willem noted that even TCP packets could be trapped there, till the next retransmission.