Re: [PATCH net v2] ipv6: route: purge exception on removal

2019-02-22 Thread David Miller
From: Paolo Abeni Date: Wed, 20 Feb 2019 18:18:12 +0100 > When a netdevice is unregistered, we flush the relevant exception > via rt6_sync_down_dev() -> fib6_ifdown() -> fib6_del() -> fib6_del_route(). > > Finally, we end-up calling rt6_remove_exception(), where we release > the relevant dst, wh

Re: [PATCH net v2] ipv6: route: purge exception on removal

2019-02-21 Thread Stefano Brivio
On Thu, 21 Feb 2019 10:10:32 -0500 David Ahern wrote: > I am surprised this was not found by the existing pmtu script which > creates exceptions. Please add this test case to selftests to capture > this specific set of events. I think the reason is that, to keep the cleanup function minimal, I j

Re: [PATCH net v2] ipv6: route: purge exception on removal

2019-02-21 Thread Paolo Abeni
On Thu, 2019-02-21 at 10:10 -0500, David Ahern wrote: > I am surprised this was not found by the existing pmtu script which > creates exceptions. Please add this test case to selftests to capture > this specific set of events. Sure, I'll have a look at the self-tests. Should I target net (since th

Re: [PATCH net v2] ipv6: route: purge exception on removal

2019-02-21 Thread David Ahern
On 2/20/19 12:18 PM, Paolo Abeni wrote: > When a netdevice is unregistered, we flush the relevant exception > via rt6_sync_down_dev() -> fib6_ifdown() -> fib6_del() -> fib6_del_route(). > > Finally, we end-up calling rt6_remove_exception(), where we release > the relevant dst, while we keep the re

[PATCH net v2] ipv6: route: purge exception on removal

2019-02-20 Thread Paolo Abeni
When a netdevice is unregistered, we flush the relevant exception via rt6_sync_down_dev() -> fib6_ifdown() -> fib6_del() -> fib6_del_route(). Finally, we end-up calling rt6_remove_exception(), where we release the relevant dst, while we keep the references to the related fib6_info and dev. Such re