Re: [PATCH net v2] fix return of iptunnel_xmit

2015-10-08 Thread Jiri Benc
On Thu, 8 Oct 2015 17:33:54 +0200, Andreas Schultz wrote: > --- a/net/ipv4/ip_tunnel_core.c > +++ b/net/ipv4/ip_tunnel_core.c > @@ -80,9 +80,12 @@ int iptunnel_xmit(struct sock *sk, struct rtable *rt, > struct sk_buff *skb, >skb_shinfo(skb)->gso_segs ?: 1); > >

Re: [PATCH net v2] fix return of iptunnel_xmit

2015-10-08 Thread Andreas Schultz
On 10/08/2015 05:08 PM, Jiri Benc wrote: On Thu, 8 Oct 2015 12:11:54 +0200, Andreas Schultz wrote: All users of iptunnel_xmit expect the return value to be the error code from ip_output_local, but currently the return value is length of the send data on success or zero on error. Change iptunnel

Re: [PATCH net v2] fix return of iptunnel_xmit

2015-10-08 Thread Jiri Benc
On Thu, 8 Oct 2015 12:11:54 +0200, Andreas Schultz wrote: > All users of iptunnel_xmit expect the return value to be the error > code from ip_output_local, but currently the return value is length > of the send data on success or zero on error. > Change iptunnel_xmit returns to match the callers e

[PATCH net v2] fix return of iptunnel_xmit

2015-10-08 Thread Andreas Schultz
All users of iptunnel_xmit expect the return value to be the error code from ip_output_local, but currently the return value is length of the send data on success or zero on error. Change iptunnel_xmit returns to match the callers expectation. This bug was introduced when the ip_tunnel_core code w