Re: [PATCH net v2] af-unix: fix use-after-free with concurrent readers while splicing

2015-11-10 Thread Eric Dumazet
On Tue, 2015-11-10 at 15:47 +0100, Hannes Frederic Sowa wrote: > During splicing an af-unix socket to a pipe we have to drop all > af-unix socket locks. While doing so we allow another reader to enter > unix_stream_read_generic which can read, copy and finally free another > skb. If exactly this sk

Re: [PATCH net v2] af-unix: fix use-after-free with concurrent readers while splicing

2015-11-10 Thread Hannes Frederic Sowa
On Tue, Nov 10, 2015, at 16:18, Eric Dumazet wrote: > Please Hannes include the Fixes: tag. Yep, sorry, is done in v3. > As you might already know, patchwork does not catch it later > > Fixes: 2b514574f7e8 ("net: af_unix: implement splice for stream af_unix > sockets") > Acked-by: Eric Dumazet

[PATCH net v2] af-unix: fix use-after-free with concurrent readers while splicing

2015-11-10 Thread Hannes Frederic Sowa
During splicing an af-unix socket to a pipe we have to drop all af-unix socket locks. While doing so we allow another reader to enter unix_stream_read_generic which can read, copy and finally free another skb. If exactly this skb is just in process of being spliced we get a use-after-free report by