Re: [PATCH net 3/3] netvsc: fix RCU warning from set_multicast

2017-06-06 Thread David Miller
From: Stephen Hemminger Date: Mon, 5 Jun 2017 14:10:10 -0700 > + nvdev = rtnl_dereference(ndevctx->nvdev); > + if (nvdev) > + rdev = nvdev->extension; > + > + if (rdev) { > + if (ndev->flags & IFF_PROMISC) > + rndis_

Re: [PATCH net 3/3] netvsc: fix RCU warning from set_multicast (fwd)

2017-06-06 Thread Julia Lawall
Please check the indentation of lines 73 onward. thanks, julia -- Forwarded message -- Date: Tue, 6 Jun 2017 14:40:59 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH net 3/3] netvsc: fix RCU warning from set_multicast CC: kbuild-...@01.org

Re: [PATCH net 3/3] netvsc: fix RCU warning from set_multicast

2017-06-05 Thread kbuild test robot
Hi Stephen, [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/Stephen-Hemminger/netvsc-bug-fixes/20170606-120730 config: x86_64-randconfig-x007-201723 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attach

Re: [PATCH net 3/3] netvsc: fix RCU warning from set_multicast

2017-06-05 Thread kbuild test robot
Hi Stephen, [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Stephen-Hemminger/netvsc-bug-fixes/20170606-120730 config: x86_64-allyesdebian (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config t

[PATCH net 3/3] netvsc: fix RCU warning from set_multicast

2017-06-05 Thread Stephen Hemminger
do_set_multicast runs in a work queue and therefore is not holding RCU read lock. This causes: WARNING: suspicious RCU usage 4.12.0-rc2-net-00284-ge23454766d55-dirty #2 Not tainted - drivers/net/hyperv/netvsc_drv.c:65 suspicious rcu_dereference_check() usage! Fix by ac