Re: [PATCH net 1/7] virtio_net: Don't enable NAPI when interface is down

2019-01-17 Thread Jason Wang
On 2019/1/17 下午7:20, Toshiaki Makita wrote: Commit 4e09ff536284 ("virtio-net: disable NAPI only when enabled during XDP set") tried to fix inappropriate NAPI enabling/disabling when !netif_running(), but was not complete. On error path virtio_net could enable NAPI even when !netif_running(). T

[PATCH net 1/7] virtio_net: Don't enable NAPI when interface is down

2019-01-17 Thread Toshiaki Makita
Commit 4e09ff536284 ("virtio-net: disable NAPI only when enabled during XDP set") tried to fix inappropriate NAPI enabling/disabling when !netif_running(), but was not complete. On error path virtio_net could enable NAPI even when !netif_running(). This can cause enabling NAPI twice on virtnet_ope