RE: [PATCH net 1/3] lan78xx: Set ASD in MAC_CR when EEE is enabled.

2018-03-23 Thread RaghuramChary.Jallipalli
Hi Sergei, > Hello! > > Only stylistic comments. Thanks for the comments. Will address them and submit in v1 patch. Thanks, -Raghu

Re: [PATCH net 1/3] lan78xx: Set ASD in MAC_CR when EEE is enabled.

2018-03-22 Thread Sergei Shtylyov
Hello! Only stylistic comments. On 3/22/2018 10:41 AM, Raghuram Chary J wrote: Description: EEE does not work with lan7800 when AutoSpeed is not set. (This can happen when EEPROM is not populated or configured incorrectly) Root-Cause: When EEE is enabled, the mac config register ASD is not

[PATCH net 1/3] lan78xx: Set ASD in MAC_CR when EEE is enabled.

2018-03-22 Thread Raghuram Chary J
Description: EEE does not work with lan7800 when AutoSpeed is not set. (This can happen when EEPROM is not populated or configured incorrectly) Root-Cause: When EEE is enabled, the mac config register ASD is not set i.e in default state,causing EEE fail. Fix: Set the register when eeprom is not p