Re: [PATCH net 1/3] bnxt_en: Fix accumulation of bp->net_stats_prev.

2020-05-26 Thread Jakub Kicinski
On Tue, 26 May 2020 15:43:52 -0700 Michael Chan wrote: > On Tue, May 26, 2020 at 3:04 PM Jakub Kicinski wrote: > > On Mon, 25 May 2020 17:41:17 -0400 Michael Chan wrote: > > > We have logic to maintain network counters across resets by storing > > > the counters in bp->net_stats_prev before rese

Re: [PATCH net 1/3] bnxt_en: Fix accumulation of bp->net_stats_prev.

2020-05-26 Thread Michael Chan
On Tue, May 26, 2020 at 3:04 PM Jakub Kicinski wrote: > > On Mon, 25 May 2020 17:41:17 -0400 Michael Chan wrote: > > We have logic to maintain network counters across resets by storing > > the counters in bp->net_stats_prev before reset. But not all resets > > will clear the counters. Certain re

Re: [PATCH net 1/3] bnxt_en: Fix accumulation of bp->net_stats_prev.

2020-05-26 Thread Jakub Kicinski
On Mon, 25 May 2020 17:41:17 -0400 Michael Chan wrote: > We have logic to maintain network counters across resets by storing > the counters in bp->net_stats_prev before reset. But not all resets > will clear the counters. Certain resets that don't need to change > the number of rings do not clear

[PATCH net 1/3] bnxt_en: Fix accumulation of bp->net_stats_prev.

2020-05-25 Thread Michael Chan
We have logic to maintain network counters across resets by storing the counters in bp->net_stats_prev before reset. But not all resets will clear the counters. Certain resets that don't need to change the number of rings do not clear the counters. The current logic accumulates the counters befo