Re: [PATCH net 1/2] of: of_mdio: Correct loop scanning logic

2020-06-19 Thread Andrew Lunn
On Thu, Jun 18, 2020 at 09:47:58PM -0700, Florian Fainelli wrote: > Commit 209c65b61d94 ("drivers/of/of_mdio.c:fix of_mdiobus_register()") > introduced a break of the loop on the premise that a successful > registration should exit the loop. The premise is correct but not to > code, because rc && r

[PATCH net 1/2] of: of_mdio: Correct loop scanning logic

2020-06-18 Thread Florian Fainelli
Commit 209c65b61d94 ("drivers/of/of_mdio.c:fix of_mdiobus_register()") introduced a break of the loop on the premise that a successful registration should exit the loop. The premise is correct but not to code, because rc && rc != -ENODEV is just a special error condition, that means we would exit t