Re: [PATCH net 1/2] net: avoid errors when trying to pop MLPS header on non-MPLS packets

2019-10-11 Thread John Hurley
On Fri, Oct 11, 2019 at 8:34 AM Simon Horman wrote: > > On Thu, Oct 10, 2019 at 08:43:52PM +0200, Davide Caratti wrote: > > the following script: > > > > # tc qdisc add dev eth0 clsact > > # tc filter add dev eth0 egress matchall action mpls pop > > > > implicitly makes the kernel drop all packe

Re: [PATCH net 1/2] net: avoid errors when trying to pop MLPS header on non-MPLS packets

2019-10-11 Thread Simon Horman
On Thu, Oct 10, 2019 at 08:43:52PM +0200, Davide Caratti wrote: > the following script: > > # tc qdisc add dev eth0 clsact > # tc filter add dev eth0 egress matchall action mpls pop > > implicitly makes the kernel drop all packets transmitted by eth0, if they > don't have a MPLS header. This be

[PATCH net 1/2] net: avoid errors when trying to pop MLPS header on non-MPLS packets

2019-10-10 Thread Davide Caratti
the following script: # tc qdisc add dev eth0 clsact # tc filter add dev eth0 egress matchall action mpls pop implicitly makes the kernel drop all packets transmitted by eth0, if they don't have a MPLS header. This behavior is uncommon: other encapsulations (like VLAN) just let the packet pass