RE: [PATCH net 1/2] devlink: Hold rtnl lock while reading netdev attributes

2020-11-25 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Wednesday, November 25, 2020 11:12 PM > > On Wed, 25 Nov 2020 17:21:41 + Parav Pandit wrote: > > > From: Jakub Kicinski > > > Sent: Wednesday, November 25, 2020 10:00 PM > > > > > > On Wed, 25 Nov 2020 07:13:40 + Parav Pandit wrote: > > > > > Maybe even a

Re: [PATCH net 1/2] devlink: Hold rtnl lock while reading netdev attributes

2020-11-25 Thread Jakub Kicinski
On Wed, 25 Nov 2020 17:21:41 + Parav Pandit wrote: > > From: Jakub Kicinski > > Sent: Wednesday, November 25, 2020 10:00 PM > > > > On Wed, 25 Nov 2020 07:13:40 + Parav Pandit wrote: > > > > Maybe even add a check that drivers > > > > which support reload set namespace local on their ne

RE: [PATCH net 1/2] devlink: Hold rtnl lock while reading netdev attributes

2020-11-25 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Wednesday, November 25, 2020 10:00 PM > > On Wed, 25 Nov 2020 07:13:40 + Parav Pandit wrote: > > > Maybe even add a check that drivers > > > which support reload set namespace local on their netdevs. > > This will break the backward compatibility as orchestra

Re: [PATCH net 1/2] devlink: Hold rtnl lock while reading netdev attributes

2020-11-25 Thread Jakub Kicinski
On Wed, 25 Nov 2020 07:13:40 + Parav Pandit wrote: > > Maybe even add a check that drivers > > which support reload set namespace local on their netdevs. > This will break the backward compatibility as orchestration for VFs > are not using devlink reload, which is supported very recently. But

RE: [PATCH net 1/2] devlink: Hold rtnl lock while reading netdev attributes

2020-11-24 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Wednesday, November 25, 2020 3:59 AM > > On Sun, 22 Nov 2020 08:12:56 +0200 Parav Pandit wrote: > > A netdevice of a devlink port can be moved to different net namespace > > than its parent devlink instance. > > This scenario occurs when devlink reload is not use

Re: [PATCH net 1/2] devlink: Hold rtnl lock while reading netdev attributes

2020-11-24 Thread Jakub Kicinski
On Sun, 22 Nov 2020 08:12:56 +0200 Parav Pandit wrote: > A netdevice of a devlink port can be moved to different > net namespace than its parent devlink instance. > This scenario occurs when devlink reload is not used for > maintaining backward compatibility. > > When netdevice is undergoing migra

[PATCH net 1/2] devlink: Hold rtnl lock while reading netdev attributes

2020-11-21 Thread Parav Pandit
A netdevice of a devlink port can be moved to different net namespace than its parent devlink instance. This scenario occurs when devlink reload is not used for maintaining backward compatibility. When netdevice is undergoing migration to net namespace, its ifindex and name may change. In such us