Re: [PATCH net 1/1] qlge: Fix netdev features configuration.

2018-08-25 Thread David Miller
From: Manish Chopra Date: Thu, 23 Aug 2018 13:20:52 -0700 > qlge_fix_features() is not supposed to modify hardware or > driver state, rather it is supposed to only fix requested > fetures bits. Currently qlge_fix_features() also goes for > interface down and up unnecessarily if there is not even

RE: [PATCH net 1/1] qlge: Fix netdev features configuration.

2018-08-23 Thread Chopra, Manish
> -Original Message- > From: Manish Chopra > Sent: Friday, August 24, 2018 2:02 AM > To: da...@davemloft.net > Cc: netdev@vger.kernel.org; Dept-GE Linux NIC Dev gelinuxnic...@cavium.com>; bpoir...@suse.com > Subject: [PATCH net 1/1] qlge: Fix netdev f

[PATCH net 1/1] qlge: Fix netdev features configuration.

2018-08-23 Thread Manish Chopra
qlge_fix_features() is not supposed to modify hardware or driver state, rather it is supposed to only fix requested fetures bits. Currently qlge_fix_features() also goes for interface down and up unnecessarily if there is not even any change in features set. This patch changes/fixes following - 1

[PATCH net 1/1] qlge: Fix netdev features configuration.

2018-08-23 Thread Manish Chopra
qlge_fix_features() is not supposed to modify hardware or driver state, rather it is supposed to only fix requested fetures bits. Currently qlge_fix_features() also goes for interface down and up unnecessarily if there is not even any change in features set. This patch changes/fixes following - 1