Re: [PATCH net-next v7 5/6] flow_offload: support get multi-subsystem block

2019-08-19 Thread Jakub Kicinski
On Mon, 19 Aug 2019 07:26:07 +, Vlad Buslov wrote: > On Fri 16 Aug 2019 at 20:56, Jakub Kicinski > wrote: > > Hi Vlad! > > > > While looking into this, would you mind also add the missing > > flow_block_cb_is_busy() calls in the indirect handlers in the drivers? > > > > LMK if you're too busy

Re: [PATCH net-next v7 5/6] flow_offload: support get multi-subsystem block

2019-08-19 Thread Vlad Buslov
On Fri 16 Aug 2019 at 20:56, Jakub Kicinski wrote: > On Fri, 16 Aug 2019 15:04:44 +, Vlad Buslov wrote: >> >> [ 401.511871] RSP: 002b:7ffca2a9fad8 EFLAGS: 0246 ORIG_RAX: >> >> 0001 >> >> [ 401.511875] RAX: ffda RBX: 0002 RCX: >> >> 7fad892

Re: [PATCH net-next v7 5/6] flow_offload: support get multi-subsystem block

2019-08-16 Thread Vlad Buslov
On Fri 16 Aug 2019 at 20:56, Jakub Kicinski wrote: > On Fri, 16 Aug 2019 15:04:44 +, Vlad Buslov wrote: >> >> [ 401.511871] RSP: 002b:7ffca2a9fad8 EFLAGS: 0246 ORIG_RAX: >> >> 0001 >> >> [ 401.511875] RAX: ffda RBX: 0002 RCX: >> >> 7fad892

Re: [PATCH net-next v7 5/6] flow_offload: support get multi-subsystem block

2019-08-16 Thread Jakub Kicinski
On Fri, 16 Aug 2019 15:04:44 +, Vlad Buslov wrote: > >> [ 401.511871] RSP: 002b:7ffca2a9fad8 EFLAGS: 0246 ORIG_RAX: > >> 0001 > >> [ 401.511875] RAX: ffda RBX: 0002 RCX: > >> 7fad892d30f8 > >> [ 401.511878] RDX: 0002 RSI: 55af

Re: [PATCH net-next v7 5/6] flow_offload: support get multi-subsystem block

2019-08-16 Thread Vlad Buslov
On Wed 14 Aug 2019 at 05:50, wenxu wrote: > On 8/12/2019 10:11 PM, Vlad Buslov wrote: >> >>> +static void flow_block_ing_cmd(struct net_device *dev, >>> + flow_indr_block_bind_cb_t *cb, >>> + void *cb_priv, >>> + enum flow_

Re: [PATCH net-next v7 5/6] flow_offload: support get multi-subsystem block

2019-08-13 Thread wenxu
On 8/12/2019 10:11 PM, Vlad Buslov wrote: > >> +static void flow_block_ing_cmd(struct net_device *dev, >> + flow_indr_block_bind_cb_t *cb, >> + void *cb_priv, >> + enum flow_block_command command) >> +{ >> +struct f

Re: [PATCH net-next v7 5/6] flow_offload: support get multi-subsystem block

2019-08-12 Thread Vlad Buslov
On Wed 07 Aug 2019 at 04:13, we...@ucloud.cn wrote: > From: wenxu > > It provide a callback list to find the blocks of tc > and nft subsystems > > Signed-off-by: wenxu > Acked-by: Jakub Kicinski > --- > v7: add a mutex lock for add/del flow_indr_block_ing_cb > > include/net/flow_offload.h | 10

[PATCH net-next v7 5/6] flow_offload: support get multi-subsystem block

2019-08-06 Thread wenxu
From: wenxu It provide a callback list to find the blocks of tc and nft subsystems Signed-off-by: wenxu Acked-by: Jakub Kicinski --- v7: add a mutex lock for add/del flow_indr_block_ing_cb include/net/flow_offload.h | 10 - net/core/flow_offload.c| 51