Re: [PATCH net-next v7] vhost_net: avoid tx queue stuck when sendmsg fails

2021-01-19 Thread Jakub Kicinski
On Tue, 19 Jan 2021 04:56:59 -0500 Michael S. Tsirkin wrote: > On Mon, Jan 18, 2021 at 02:33:29PM -0800, Jakub Kicinski wrote: > > On Fri, 15 Jan 2021 12:46:20 +0800 wangyunjian wrote: > > > From: Yunjian Wang > > > > > > Currently the driver doesn't drop a packet which can't be sent by tun > >

Re: [PATCH net-next v7] vhost_net: avoid tx queue stuck when sendmsg fails

2021-01-19 Thread Michael S. Tsirkin
On Mon, Jan 18, 2021 at 02:33:29PM -0800, Jakub Kicinski wrote: > On Fri, 15 Jan 2021 12:46:20 +0800 wangyunjian wrote: > > From: Yunjian Wang > > > > Currently the driver doesn't drop a packet which can't be sent by tun > > (e.g bad packet). In this case, the driver will always process the > > s

Re: [PATCH net-next v7] vhost_net: avoid tx queue stuck when sendmsg fails

2021-01-19 Thread Michael S. Tsirkin
On Fri, Jan 15, 2021 at 12:46:20PM +0800, wangyunjian wrote: > From: Yunjian Wang > > Currently the driver doesn't drop a packet which can't be sent by tun > (e.g bad packet). In this case, the driver will always process the > same packet lead to the tx queue stuck. > > To fix this issue: > 1. i

Re: [PATCH net-next v7] vhost_net: avoid tx queue stuck when sendmsg fails

2021-01-18 Thread Jakub Kicinski
On Fri, 15 Jan 2021 12:46:20 +0800 wangyunjian wrote: > From: Yunjian Wang > > Currently the driver doesn't drop a packet which can't be sent by tun > (e.g bad packet). In this case, the driver will always process the > same packet lead to the tx queue stuck. > > To fix this issue: > 1. in the c

Re: [PATCH net-next v7] vhost_net: avoid tx queue stuck when sendmsg fails

2021-01-15 Thread Willem de Bruijn
On Fri, Jan 15, 2021 at 1:12 AM Jason Wang wrote: > > > On 2021/1/15 下午12:46, wangyunjian wrote: > > From: Yunjian Wang > > > > Currently the driver doesn't drop a packet which can't be sent by tun > > (e.g bad packet). In this case, the driver will always process the > > same packet lead to the

Re: [PATCH net-next v7] vhost_net: avoid tx queue stuck when sendmsg fails

2021-01-14 Thread Jason Wang
On 2021/1/15 下午12:46, wangyunjian wrote: From: Yunjian Wang Currently the driver doesn't drop a packet which can't be sent by tun (e.g bad packet). In this case, the driver will always process the same packet lead to the tx queue stuck. To fix this issue: 1. in the case of persistent failure

[PATCH net-next v7] vhost_net: avoid tx queue stuck when sendmsg fails

2021-01-14 Thread wangyunjian
From: Yunjian Wang Currently the driver doesn't drop a packet which can't be sent by tun (e.g bad packet). In this case, the driver will always process the same packet lead to the tx queue stuck. To fix this issue: 1. in the case of persistent failure (e.g bad packet), the driver can skip thi