Re: [PATCH net-next v6 1/1] net sched actions: Add support for user cookies

2017-01-24 Thread Jamal Hadi Salim
On 17-01-23 11:18 AM, Daniel Borkmann wrote: On 01/23/2017 01:58 PM, Simon Horman wrote: Hi Jamal, On Sun, Jan 22, 2017 at 03:25:50PM -0500, Jamal Hadi Salim wrote: ... diff --git a/net/sched/act_api.c b/net/sched/act_api.c index cd08df9..58cf1c5 100644 --- a/net/sched/act_api.c +++ b/net/sc

Re: [PATCH net-next v6 1/1] net sched actions: Add support for user cookies

2017-01-24 Thread Jamal Hadi Salim
On 17-01-23 07:58 AM, Simon Horman wrote: Hi Jamal, On Sun, Jan 22, 2017 at 03:25:50PM -0500, Jamal Hadi Salim wrote: ... @@ -33,6 +34,8 @@ static void free_tcf(struct rcu_head *head) free_percpu(p->cpu_bstats); free_percpu(p->cpu_qstats); + kfree(p->act_cookie->data)

Re: [PATCH net-next v6 1/1] net sched actions: Add support for user cookies

2017-01-23 Thread Daniel Borkmann
On 01/23/2017 01:58 PM, Simon Horman wrote: Hi Jamal, On Sun, Jan 22, 2017 at 03:25:50PM -0500, Jamal Hadi Salim wrote: ... diff --git a/net/sched/act_api.c b/net/sched/act_api.c index cd08df9..58cf1c5 100644 --- a/net/sched/act_api.c +++ b/net/sched/act_api.c @@ -24,6 +24,7 @@ #include

Re: [PATCH net-next v6 1/1] net sched actions: Add support for user cookies

2017-01-23 Thread Simon Horman
Hi Jamal, On Sun, Jan 22, 2017 at 03:25:50PM -0500, Jamal Hadi Salim wrote: ... > diff --git a/net/sched/act_api.c b/net/sched/act_api.c > index cd08df9..58cf1c5 100644 > --- a/net/sched/act_api.c > +++ b/net/sched/act_api.c > @@ -24,6 +24,7 @@ > #include > #include > #include > +#include

Re: [PATCH net-next v6 1/1] net sched actions: Add support for user cookies

2017-01-22 Thread Jiri Pirko
Sun, Jan 22, 2017 at 09:25:50PM CET, j...@mojatatu.com wrote: >From: Jamal Hadi Salim > >Introduce optional 128-bit action cookie. >Like all other cookie schemes in the networking world (eg in protocols >like http or existing kernel fib protocol field, etc) the idea is to save >user state that whe

[PATCH net-next v6 1/1] net sched actions: Add support for user cookies

2017-01-22 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Introduce optional 128-bit action cookie. Like all other cookie schemes in the networking world (eg in protocols like http or existing kernel fib protocol field, etc) the idea is to save user state that when retrieved serves as a correlator. The kernel _should not_ intepret