Re: [PATCH net-next v6 08/11] net: sched: don't release reference on action overwrite

2018-08-14 Thread Vlad Buslov
On Mon 13 Aug 2018 at 23:00, Cong Wang wrote: > On Thu, Jul 5, 2018 at 7:24 AM Vlad Buslov wrote: >> diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c >> index 89a761395c94..acea3feae762 100644 >> --- a/net/sched/act_ife.c >> +++ b/net/sched/act_ife.c > ... >> @@ -548,6 +546,8 @@ static int

Re: [PATCH net-next v6 08/11] net: sched: don't release reference on action overwrite

2018-08-13 Thread Cong Wang
On Thu, Jul 5, 2018 at 7:24 AM Vlad Buslov wrote: > diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c > index 89a761395c94..acea3feae762 100644 > --- a/net/sched/act_ife.c > +++ b/net/sched/act_ife.c ... > @@ -548,6 +546,8 @@ static int tcf_ife_init(struct net *net, struct nlattr > *nla, > >

[PATCH net-next v6 08/11] net: sched: don't release reference on action overwrite

2018-07-05 Thread Vlad Buslov
Return from action init function with reference to action taken, even when overwriting existing action. Action init API initializes its fourth argument (pointer to pointer to tc action) to either existing action with same index or newly created action. In case of existing index(and bind argument i