Re: [PATCH net-next v6 04/11] ipv4: Dump route exceptions if requested

2019-06-20 Thread David Ahern
On 6/20/19 1:01 PM, Stefano Brivio wrote: >>> diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c >>> index 94e5d83db4db..03f51e5192e5 100644 >>> --- a/net/ipv4/fib_trie.c >>> +++ b/net/ipv4/fib_trie.c >>> @@ -2078,28 +2078,51 @@ void fib_free_table(struct fib_table *tb) >>> call_rcu(&tb->rc

Re: [PATCH net-next v6 04/11] ipv4: Dump route exceptions if requested

2019-06-20 Thread Stefano Brivio
On Thu, 20 Jun 2019 07:31:32 -0600 David Ahern wrote: > On 6/19/19 5:59 PM, Stefano Brivio wrote: > > diff --git a/include/net/route.h b/include/net/route.h > > index 065b47754f05..e7f65388a6d4 100644 > > --- a/include/net/route.h > > +++ b/include/net/route.h > > @@ -44,6 +44,7 @@ > > #define R

Re: [PATCH net-next v6 04/11] ipv4: Dump route exceptions if requested

2019-06-20 Thread David Ahern
On 6/19/19 5:59 PM, Stefano Brivio wrote: > diff --git a/include/net/route.h b/include/net/route.h > index 065b47754f05..e7f65388a6d4 100644 > --- a/include/net/route.h > +++ b/include/net/route.h > @@ -44,6 +44,7 @@ > #define RT_CONN_FLAGS_TOS(sk,tos) (RT_TOS(tos) | sock_flag(sk, > SOCK_LOCALR

[PATCH net-next v6 04/11] ipv4: Dump route exceptions if requested

2019-06-19 Thread Stefano Brivio
Since commit 4895c771c7f0 ("ipv4: Add FIB nexthop exceptions."), cached exception routes are stored as a separate entity, so they are not dumped on a FIB dump, even if the RTM_F_CLONED flag is passed. This implies that the command 'ip route list cache' doesn't return any result anymore. If the RT