On Wed, Jun 12, 2019 at 02:34:58PM -0700, Jakub Kicinski wrote:
> On Wed, 12 Jun 2019 21:18:59 +0200, Michal Kubecek wrote:
> > On Wed, Jun 12, 2019 at 08:56:10PM +0200, Johannes Berg wrote:
> > > (switching to my personal email)
> > >
> > > > > I can't add these actions with current net-next an
On Thu, Jun 13, 2019 at 09:09:47AM +, Kevin 'ldir' Darbyshire-Bryant wrote:
>
>
> > On 13 Jun 2019, at 10:33, Simon Horman wrote:
> >
> > On Wed, Jun 12, 2019 at 11:46:27AM -0700, Jakub Kicinski wrote:
> >> On Wed, 12 Jun 2019 15:02:39 -0300, Marcelo Ricardo Leitner wrote:
> >>> On Tue, May
On Wed, 12 Jun 2019 21:18:59 +0200, Michal Kubecek wrote:
> On Wed, Jun 12, 2019 at 08:56:10PM +0200, Johannes Berg wrote:
> > (switching to my personal email)
> >
> > > > I can't add these actions with current net-next and iproute-next:
> > > > # ~/iproute2/tc/tc action add action ctinfo dscp 0
On Wed, Jun 12, 2019 at 11:46:27AM -0700, Jakub Kicinski wrote:
> On Wed, 12 Jun 2019 15:02:39 -0300, Marcelo Ricardo Leitner wrote:
> > On Tue, May 28, 2019 at 05:03:50PM +, Kevin 'ldir' Darbyshire-Bryant
> > wrote:
> > ...
> > > +static int tcf_ctinfo_init(struct net *net, struct nlattr *nla
> On 13 Jun 2019, at 10:33, Simon Horman wrote:
>
> On Wed, Jun 12, 2019 at 11:46:27AM -0700, Jakub Kicinski wrote:
>> On Wed, 12 Jun 2019 15:02:39 -0300, Marcelo Ricardo Leitner wrote:
>>> On Tue, May 28, 2019 at 05:03:50PM +, Kevin 'ldir' Darbyshire-Bryant
>>> wrote:
>>> ...
+static
> On 13 Jun 2019, at 11:09, Kevin 'ldir' Darbyshire-Bryant
> wrote:
>
>
> Warning: Not even compile tested! Am I heading in the right direction?
>
I think this is even better. Does it help? Clues before I send as proper
patch :-)
Subject: [PATCH] sched: act_ctinfo: use extack error r
Kevin 'ldir' Darbyshire-Bryant writes:
>> On 13 Jun 2019, at 10:33, Simon Horman wrote:
>>
>> On Wed, Jun 12, 2019 at 11:46:27AM -0700, Jakub Kicinski wrote:
>>> On Wed, 12 Jun 2019 15:02:39 -0300, Marcelo Ricardo Leitner wrote:
On Tue, May 28, 2019 at 05:03:50PM +, Kevin 'ldir' Darbys
On Wed, Jun 12, 2019 at 08:56:10PM +0200, Johannes Berg wrote:
> (switching to my personal email)
>
> > > I can't add these actions with current net-next and iproute-next:
> > > # ~/iproute2/tc/tc action add action ctinfo dscp 0xfc00 0x0100
> > > Error: NLA_F_NESTED is missing.
> > > We ha
(switching to my personal email)
> > I can't add these actions with current net-next and iproute-next:
> > # ~/iproute2/tc/tc action add action ctinfo dscp 0xfc00 0x0100
> > Error: NLA_F_NESTED is missing.
> > We have an error talking to the kernel
> >
> > This also happens with the curre
On Wed, Jun 12, 2019 at 11:46:27AM -0700, Jakub Kicinski wrote:
> On Wed, 12 Jun 2019 15:02:39 -0300, Marcelo Ricardo Leitner wrote:
> > On Tue, May 28, 2019 at 05:03:50PM +, Kevin 'ldir' Darbyshire-Bryant
> > wrote:
> > ...
> > > +static int tcf_ctinfo_init(struct net *net, struct nlattr *nla
On Wed, 12 Jun 2019 15:02:39 -0300, Marcelo Ricardo Leitner wrote:
> On Tue, May 28, 2019 at 05:03:50PM +, Kevin 'ldir' Darbyshire-Bryant
> wrote:
> ...
> > +static int tcf_ctinfo_init(struct net *net, struct nlattr *nla,
> > + struct nlattr *est, struct tc_action **a,
> >
On Tue, May 28, 2019 at 05:03:50PM +, Kevin 'ldir' Darbyshire-Bryant wrote:
...
> +static int tcf_ctinfo_init(struct net *net, struct nlattr *nla,
> +struct nlattr *est, struct tc_action **a,
> +int ovr, int bind, bool rtnl_held,
> +
> On 30 May 2019, at 05:44, David Miller wrote:
>
> From: Kevin 'ldir' Darbyshire-Bryant
> Date: Tue, 28 May 2019 17:03:50 +
>
>> ctinfo is a new tc filter action module. It is designed to restore
>> information contained in firewall conntrack marks to other packet fields
>> and is typic
From: Kevin 'ldir' Darbyshire-Bryant
Date: Tue, 28 May 2019 17:03:50 +
> ctinfo is a new tc filter action module. It is designed to restore
> information contained in firewall conntrack marks to other packet fields
> and is typically used on packet ingress paths. At present it has two
> ind
On Tue, May 28, 2019 at 10:05 AM Kevin 'ldir' Darbyshire-Bryant
wrote:
>
> ctinfo is a new tc filter action module. It is designed to restore
> information contained in firewall conntrack marks to other packet fields
> and is typically used on packet ingress paths. At present it has two
> indepe
Kevin 'ldir' Darbyshire-Bryant writes:
>> On 28 May 2019, at 19:08, Toke Høiland-Jørgensen wrote:
>>
>
>>
>> Thank you for doing another iteration!
>>
>> No further comments on the actual code, but I still get the whitespace
>> issue with the patch... And now it results in stray ^M character
> On 28 May 2019, at 19:08, Toke Høiland-Jørgensen wrote:
>
>
> Thank you for doing another iteration!
>
> No further comments on the actual code, but I still get the whitespace
> issue with the patch... And now it results in stray ^M characters in the
> Kconfig file, which makes the build b
Kevin 'ldir' Darbyshire-Bryant writes:
> ctinfo is a new tc filter action module. It is designed to restore
> information contained in firewall conntrack marks to other packet fields
> and is typically used on packet ingress paths. At present it has two
> independent sub-functions or operating
ctinfo is a new tc filter action module. It is designed to restore
information contained in firewall conntrack marks to other packet fields
and is typically used on packet ingress paths. At present it has two
independent sub-functions or operating modes, DSCP restoration mode &
skb mark restorati
19 matches
Mail list logo
