Re: [PATCH net-next v5 4/4] virtio-net: support dim profile fine-tuning

2024-04-10 Thread Jakub Kicinski
On Wed, 10 Apr 2024 11:09:16 +0800 Heng Qi wrote: > The point is that the driver may check whether the user has set > parameters that it does not want. > For example, virtio may not want the modification of comps, and ice/idpf > may not want the modification > of comps and pkts. If it's simply a

Re: [PATCH net-next v5 4/4] virtio-net: support dim profile fine-tuning

2024-04-09 Thread Heng Qi
在 2024/4/10 上午9:40, Jakub Kicinski 写道: On Tue, 9 Apr 2024 20:03:24 +0800 Heng Qi wrote: + /* DIM profile list */ + struct dim_cq_moder rx_eqe_conf[NET_DIM_PARAMS_NUM_PROFILES]; Can you please wrap this into a structure with other necessary information and add a pointer in struct

Re: [PATCH net-next v5 4/4] virtio-net: support dim profile fine-tuning

2024-04-09 Thread Jakub Kicinski
On Tue, 9 Apr 2024 20:03:24 +0800 Heng Qi wrote: > + /* DIM profile list */ > + struct dim_cq_moder rx_eqe_conf[NET_DIM_PARAMS_NUM_PROFILES]; Can you please wrap this into a structure with other necessary information and add a pointer in struct net_device instead. What's the point of eve

[PATCH net-next v5 4/4] virtio-net: support dim profile fine-tuning

2024-04-09 Thread Heng Qi
Virtio-net has different types of back-end device implementations. In order to effectively optimize the dim library's gains for different device implementations, let's use the new interface params to fine-tune the profile list. Signed-off-by: Heng Qi --- drivers/net/virtio_net.c | 41 +++