Re: [PATCH net-next v5 2/2] virtio_net: add ethtool support for set and get of settings

2016-02-04 Thread Nikolay Aleksandrov
On 02/04/2016 01:21 PM, Michael S. Tsirkin wrote: > On Wed, Feb 03, 2016 at 04:04:37AM +0100, Nikolay Aleksandrov wrote: >> From: Nikolay Aleksandrov [snip] >> struct padded_vnet_hdr { >> @@ -1376,6 +1380,58 @@ static void virtnet_get_channels(struct net_device >> *dev, >> channels->other_c

Re: [PATCH net-next v5 2/2] virtio_net: add ethtool support for set and get of settings

2016-02-04 Thread Michael S. Tsirkin
On Wed, Feb 03, 2016 at 10:19:04AM +0100, Nikolay Aleksandrov wrote: > On 02/03/2016 04:04 AM, Nikolay Aleksandrov wrote: > > From: Nikolay Aleksandrov > > > > This patch allows the user to set and retrieve speed and duplex of the > > virtio_net device via ethtool. Having this functionality is ve

Re: [PATCH net-next v5 2/2] virtio_net: add ethtool support for set and get of settings

2016-02-04 Thread Michael S. Tsirkin
On Wed, Feb 03, 2016 at 04:04:37AM +0100, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > This patch allows the user to set and retrieve speed and duplex of the > virtio_net device via ethtool. Having this functionality is very helpful > for simulating different environments and also e

Re: [PATCH net-next v5 2/2] virtio_net: add ethtool support for set and get of settings

2016-02-03 Thread Nikolay Aleksandrov
On 02/03/2016 04:04 AM, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > This patch allows the user to set and retrieve speed and duplex of the > virtio_net device via ethtool. Having this functionality is very helpful > for simulating different environments and also enables the virtio_

[PATCH net-next v5 2/2] virtio_net: add ethtool support for set and get of settings

2016-02-02 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This patch allows the user to set and retrieve speed and duplex of the virtio_net device via ethtool. Having this functionality is very helpful for simulating different environments and also enables the virtio_net device to participate in operations where proper speed an