Re: [PATCH net-next v5 1/5] netlink: extended ACK reporting

2017-04-12 Thread David Ahern
On 4/12/17 6:34 AM, Johannes Berg wrote: > From: Johannes Berg > > Add the base infrastructure and UAPI for netlink extended ACK > reporting. All "manual" calls to netlink_ack() pass NULL for > now and thus don't get extended ACK reporting. > > Big thanks goes to Pablo Neira Ayuso for not only b

Re: [PATCH net-next v5 1/5] netlink: extended ACK reporting

2017-04-12 Thread David Miller
From: Johannes Berg Date: Wed, 12 Apr 2017 17:21:43 +0200 > On Wed, 2017-04-12 at 09:06 -0600, David Ahern wrote: >> >> There was a discussion about side effects of adding strings (bloat, >> internationalization). Should ATTR_MSG be removed until that is >> ironed out? Leaving it in suggests it

Re: [PATCH net-next v5 1/5] netlink: extended ACK reporting

2017-04-12 Thread David Miller
From: Jiri Pirko Date: Wed, 12 Apr 2017 17:13:03 +0200 > Wed, Apr 12, 2017 at 05:06:48PM CEST, d...@cumulusnetworks.com wrote: >>On 4/12/17 6:34 AM, Johannes Berg wrote: >>> diff --git a/include/uapi/linux/netlink.h b/include/uapi/linux/netlink.h >>> index b2c9c26ea30f..7df88770e029 100644 >>> --

Re: [PATCH net-next v5 1/5] netlink: extended ACK reporting

2017-04-12 Thread Johannes Berg
On Wed, 2017-04-12 at 09:06 -0600, David Ahern wrote: > > There was a discussion about side effects of adding strings (bloat, > internationalization). Should ATTR_MSG be removed until that is > ironed out? Leaving it in suggests it is ok to start adding strings. I really do want the strings; this

Re: [PATCH net-next v5 1/5] netlink: extended ACK reporting

2017-04-12 Thread Jiri Pirko
Wed, Apr 12, 2017 at 05:06:48PM CEST, d...@cumulusnetworks.com wrote: >On 4/12/17 6:34 AM, Johannes Berg wrote: >> diff --git a/include/uapi/linux/netlink.h b/include/uapi/linux/netlink.h >> index b2c9c26ea30f..7df88770e029 100644 >> --- a/include/uapi/linux/netlink.h >> +++ b/include/uapi/linux/ne

Re: [PATCH net-next v5 1/5] netlink: extended ACK reporting

2017-04-12 Thread David Ahern
On 4/12/17 6:34 AM, Johannes Berg wrote: > diff --git a/include/uapi/linux/netlink.h b/include/uapi/linux/netlink.h > index b2c9c26ea30f..7df88770e029 100644 > --- a/include/uapi/linux/netlink.h > +++ b/include/uapi/linux/netlink.h > @@ -69,6 +69,10 @@ struct nlmsghdr { > #define NLM_F_CREATE 0x40

Re: [PATCH net-next v5 1/5] netlink: extended ACK reporting

2017-04-12 Thread Jiri Pirko
Wed, Apr 12, 2017 at 02:34:04PM CEST, johan...@sipsolutions.net wrote: >From: Johannes Berg > >Add the base infrastructure and UAPI for netlink extended ACK >reporting. All "manual" calls to netlink_ack() pass NULL for >now and thus don't get extended ACK reporting. > >Big thanks goes to Pablo Nei

[PATCH net-next v5 1/5] netlink: extended ACK reporting

2017-04-12 Thread Johannes Berg
From: Johannes Berg Add the base infrastructure and UAPI for netlink extended ACK reporting. All "manual" calls to netlink_ack() pass NULL for now and thus don't get extended ACK reporting. Big thanks goes to Pablo Neira Ayuso for not only bringing up the whole topic at netconf (again) but also