Re: [PATCH net-next v5 1/1] net sched actions: Add support for user cookies

2017-01-22 Thread Jamal Hadi Salim
On 17-01-22 02:32 PM, Jiri Pirko wrote: Sun, Jan 22, 2017 at 07:57:17PM CET, j...@mojatatu.com wrote: On 17-01-22 01:13 PM, Florian Fainelli wrote: + a->act_cookie->data = nla_memdup(tb[TCA_ACT_COOKIE], +GFP_KERNEL); +

Re: [PATCH net-next v5 1/1] net sched actions: Add support for user cookies

2017-01-22 Thread Jiri Pirko
Sun, Jan 22, 2017 at 07:57:17PM CET, j...@mojatatu.com wrote: >On 17-01-22 01:13 PM, Florian Fainelli wrote: >> >> > >> >> > + a->act_cookie->data = nla_memdup(tb[TCA_ACT_COOKIE], >> > + GFP_KERNEL); >> > + if (!a->act_cookie->data) { >

Re: [PATCH net-next v5 1/1] net sched actions: Add support for user cookies

2017-01-22 Thread Jamal Hadi Salim
On 17-01-22 01:13 PM, Florian Fainelli wrote: + a->act_cookie->data = nla_memdup(tb[TCA_ACT_COOKIE], +GFP_KERNEL); + if (!a->act_cookie->data) { + err = -ENOMEM; + tcf_ha

Re: [PATCH net-next v5 1/1] net sched actions: Add support for user cookies

2017-01-22 Thread Florian Fainelli
On 01/22/2017 04:51 AM, Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > Introduce optional 128-bit action cookie. > Like all other cookie schemes in the networking world (eg in protocols > like http or existing kernel fib protocol field, etc) the idea is to save > user state that when retr

[PATCH net-next v5 1/1] net sched actions: Add support for user cookies

2017-01-22 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Introduce optional 128-bit action cookie. Like all other cookie schemes in the networking world (eg in protocols like http or existing kernel fib protocol field, etc) the idea is to save user state that when retrieved serves as a correlator. The kernel _should not_ intepret