Re: [PATCH net-next v4 2/6] net: qualcomm: rmnet: simplify some byte order logic

2021-03-15 Thread Alex Elder
On 3/15/21 11:02 AM, Alexander Duyck wrote: On Mon, Mar 15, 2021 at 6:36 AM Alex Elder wrote: In rmnet_map_ipv4_ul_csum_header() and rmnet_map_ipv6_ul_csum_header() the offset within a packet at which checksumming should commence is calculated. This calculation involves byte swapping and a fo

Re: [PATCH net-next v4 2/6] net: qualcomm: rmnet: simplify some byte order logic

2021-03-15 Thread Alexander Duyck
On Mon, Mar 15, 2021 at 6:36 AM Alex Elder wrote: > > In rmnet_map_ipv4_ul_csum_header() and rmnet_map_ipv6_ul_csum_header() > the offset within a packet at which checksumming should commence is > calculated. This calculation involves byte swapping and a forced type > conversion that makes it har

[PATCH net-next v4 2/6] net: qualcomm: rmnet: simplify some byte order logic

2021-03-15 Thread Alex Elder
In rmnet_map_ipv4_ul_csum_header() and rmnet_map_ipv6_ul_csum_header() the offset within a packet at which checksumming should commence is calculated. This calculation involves byte swapping and a forced type conversion that makes it hard to understand. Simplify this by computing the offset in ho