Re: [PATCH net-next v4 1/5] netlink: extended ACK reporting

2017-04-11 Thread Jiri Pirko
Tue, Apr 11, 2017 at 10:29:52AM CEST, johan...@sipsolutions.net wrote: >On Tue, 2017-04-11 at 10:13 +0200, Jiri Pirko wrote: >> Tue, Apr 11, 2017 at 09:29:18AM CEST, johan...@sipsolutions.net >> wrote: >> > On Tue, 2017-04-11 at 09:19 +0200, Jiri Pirko wrote: >> > > >> > > > + NUM_NLMSGERR_AT

Re: [PATCH net-next v4 1/5] netlink: extended ACK reporting

2017-04-11 Thread Johannes Berg
On Tue, 2017-04-11 at 10:13 +0200, Jiri Pirko wrote: > Tue, Apr 11, 2017 at 09:29:18AM CEST, johan...@sipsolutions.net > wrote: > > On Tue, 2017-04-11 at 09:19 +0200, Jiri Pirko wrote: > > > > > > > + NUM_NLMSGERR_ATTRS, > > > > > > According to the rest of the uapi, this should be rather n

Re: [PATCH net-next v4 1/5] netlink: extended ACK reporting

2017-04-11 Thread Jiri Pirko
Tue, Apr 11, 2017 at 09:29:18AM CEST, johan...@sipsolutions.net wrote: >On Tue, 2017-04-11 at 09:19 +0200, Jiri Pirko wrote: >> >> > + NUM_NLMSGERR_ATTRS, >> >> According to the rest of the uapi, this should be rather named: >> __NLMSGERR_ATTR_MAX > >nl80211 uses NUM_ so I guess that's a ma

Re: [PATCH net-next v4 1/5] netlink: extended ACK reporting

2017-04-11 Thread Johannes Berg
On Tue, 2017-04-11 at 09:19 +0200, Jiri Pirko wrote: > > > + NUM_NLMSGERR_ATTRS, > > According to the rest of the uapi, this should be rather named: > __NLMSGERR_ATTR_MAX nl80211 uses NUM_ so I guess that's a matter of convention, but I can change that I guess. > > if (err |

Re: [PATCH net-next v4 1/5] netlink: extended ACK reporting

2017-04-11 Thread Jiri Pirko
Tue, Apr 11, 2017 at 08:56:56AM CEST, johan...@sipsolutions.net wrote: >From: Johannes Berg > >Add the base infrastructure and UAPI for netlink >extended ACK reporting. All "manual" calls to >netlink_ack() pass NULL for now and thus don't >get extended ACK reporting. > >Big thanks goes to Pablo Ne

Re: [PATCH net-next v4 1/5] netlink: extended ACK reporting

2017-04-11 Thread Jiri Pirko
Tue, Apr 11, 2017 at 08:56:56AM CEST, johan...@sipsolutions.net wrote: >From: Johannes Berg > >Add the base infrastructure and UAPI for netlink >extended ACK reporting. All "manual" calls to >netlink_ack() pass NULL for now and thus don't >get extended ACK reporting. Johannes, I asked already why

[PATCH net-next v4 1/5] netlink: extended ACK reporting

2017-04-10 Thread Johannes Berg
From: Johannes Berg Add the base infrastructure and UAPI for netlink extended ACK reporting. All "manual" calls to netlink_ack() pass NULL for now and thus don't get extended ACK reporting. Big thanks goes to Pablo Neira Ayuso for not only bringing up the whole topic at netconf (again) but also