Re: [PATCH net-next v4 07/10] bridge: cfm: Netlink SET configuration Interface.

2020-10-12 Thread henrik.bjoernl...@microchip.com
The 10/09/2020 21:53, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote: > > This is the implementation of CFM netlink configuration > > set information interface

Re: [PATCH net-next v4 07/10] bridge: cfm: Netlink SET configuration Interface.

2020-10-12 Thread Henrik Bjoernlund
Thanks for the review. Comments below. The 10/09/2020 18:45, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, 9 Oct 2020 14:35:27 + Henrik Bjoernlund wrote: > > +static inline struct mac_addr nla_get_mac(const st

Re: [PATCH net-next v4 07/10] bridge: cfm: Netlink SET configuration Interface.

2020-10-09 Thread Jakub Kicinski
On Fri, 9 Oct 2020 14:35:27 + Henrik Bjoernlund wrote: > +static inline struct mac_addr nla_get_mac(const struct nlattr *nla) static inlines are generally not needed in C sources and just hide unused code. Please drop the inline annotation. > +{ > + struct mac_addr mac; > + > + nla_me

Re: [PATCH net-next v4 07/10] bridge: cfm: Netlink SET configuration Interface.

2020-10-09 Thread Nikolay Aleksandrov
On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote: > This is the implementation of CFM netlink configuration > set information interface. > > Add new nested netlink attributes. These attributes are used by the > user space to create/delete/configure CFM instances. > > SETLINK: > IFLA

[PATCH net-next v4 07/10] bridge: cfm: Netlink SET configuration Interface.

2020-10-09 Thread Henrik Bjoernlund
This is the implementation of CFM netlink configuration set information interface. Add new nested netlink attributes. These attributes are used by the user space to create/delete/configure CFM instances. SETLINK: IFLA_BRIDGE_CFM: Indicate that the following attributes are CFM. IF