Re: [PATCH net-next v4 00/11] Modify action API for implementing lockless actions

2018-06-01 Thread Vlad Buslov
On Fri 01 Jun 2018 at 12:24, Jamal Hadi Salim wrote: > On 31/05/18 08:38 AM, Vlad Buslov wrote: > >> Hi Jamal, >> >> On current net-next I still have action with single reference after last >> step: >> ~$ sudo $TC -s actions ls action skbedit >> total acts 1 >>

Re: [PATCH net-next v4 00/11] Modify action API for implementing lockless actions

2018-06-01 Thread Jamal Hadi Salim
On 31/05/18 08:38 AM, Vlad Buslov wrote: Hi Jamal, On current net-next I still have action with single reference after last step: ~$ sudo $TC -s actions ls action skbedit total acts 1 action order 0: skbedit mark 1 pipe

Re: [PATCH net-next v4 00/11] Modify action API for implementing lockless actions

2018-05-31 Thread Vlad Buslov
On Thu 31 May 2018 at 10:01, Jamal Hadi Salim wrote: > Hi Vlad, > > Can you try one simple test below with these patches? > > #create an action > sudo $TC actions add action skbedit mark 1 pipe > # > sudo $TC qdisc del dev lo parent : > sudo $TC qdisc add dev lo ingress > # bind action to fi

Re: [PATCH net-next v4 00/11] Modify action API for implementing lockless actions

2018-05-31 Thread Jamal Hadi Salim
Hi Vlad, Can you try one simple test below with these patches? #create an action sudo $TC actions add action skbedit mark 1 pipe # sudo $TC qdisc del dev lo parent : sudo $TC qdisc add dev lo ingress # bind action to filter sudo $TC filter add dev lo parent : protocol ip prio 1 \ u32

[PATCH net-next v4 00/11] Modify action API for implementing lockless actions

2018-05-31 Thread Vlad Buslov
Currently, all netlink protocol handlers for updating rules, actions and qdiscs are protected with single global rtnl lock which removes any possibility for parallelism. This patch set is a first step to remove rtnl lock dependency from TC rules update path. Recently, new rtnl registration flag RT