Re: [PATCH net-next v3 6/8] igc: Add support for tuning frame preemption via ethtool

2021-03-02 Thread Vladimir Oltean
On Fri, Jan 22, 2021 at 02:44:51PM -0800, Vinicius Costa Gomes wrote: > diff --git a/drivers/net/ethernet/intel/igc/igc_defines.h > b/drivers/net/ethernet/intel/igc/igc_defines.h > index 0e78abfd99ee..c2155d109bd6 100644 > --- a/drivers/net/ethernet/intel/igc/igc_defines.h > +++ b/drivers/net/ethe

Re: [PATCH net-next v3 6/8] igc: Add support for tuning frame preemption via ethtool

2021-01-29 Thread Vladimir Oltean
On Fri, Jan 29, 2021 at 01:27:28PM -0800, Vinicius Costa Gomes wrote: > >> +static int igc_ethtool_set_preempt(struct net_device *netdev, > >> + struct ethtool_fp *fpcmd, > >> + struct netlink_ext_ack *extack) > >> +{ > >> + struct igc_adapte

Re: [PATCH net-next v3 6/8] igc: Add support for tuning frame preemption via ethtool

2021-01-29 Thread Vinicius Costa Gomes
Vladimir Oltean writes: > On Fri, Jan 22, 2021 at 02:44:51PM -0800, Vinicius Costa Gomes wrote: >> The tc subsystem sets which queues are marked as preemptible, it's the >> role of ethtool to control more hardware specific parameters. These >> parameters include: >> >> - enabling the frame pree

Re: [PATCH net-next v3 6/8] igc: Add support for tuning frame preemption via ethtool

2021-01-26 Thread Vladimir Oltean
On Fri, Jan 22, 2021 at 02:44:51PM -0800, Vinicius Costa Gomes wrote: > The tc subsystem sets which queues are marked as preemptible, it's the > role of ethtool to control more hardware specific parameters. These > parameters include: > > - enabling the frame preemption hardware: As enabling fram

[PATCH net-next v3 6/8] igc: Add support for tuning frame preemption via ethtool

2021-01-22 Thread Vinicius Costa Gomes
The tc subsystem sets which queues are marked as preemptible, it's the role of ethtool to control more hardware specific parameters. These parameters include: - enabling the frame preemption hardware: As enabling frame preemption may have other requirements before it can be enabled, it's expose