Re: [PATCH net-next v3 3/4] selftests: extract common functions in ethtool-common.sh

2020-11-16 Thread Antonio Cardace
On Mon, Nov 16, 2020 at 05:17:02PM +0100, Michal Kubecek wrote: > On Sat, Nov 14, 2020 at 12:16:54AM +0100, Antonio Cardace wrote: > > Factor out some useful functions so that they can be reused > > by other ethtool-netdevsim scripts. > > > > Signed-off-by: Antonio Cardace > > Reviewed-by: Micha

Re: [PATCH net-next v3 3/4] selftests: extract common functions in ethtool-common.sh

2020-11-16 Thread Michal Kubecek
On Sat, Nov 14, 2020 at 12:16:54AM +0100, Antonio Cardace wrote: > Factor out some useful functions so that they can be reused > by other ethtool-netdevsim scripts. > > Signed-off-by: Antonio Cardace Reviewed-by: Michal Kubecek Just one comment: [...] > +function get_netdev_name { > +loca

[PATCH net-next v3 3/4] selftests: extract common functions in ethtool-common.sh

2020-11-13 Thread Antonio Cardace
Factor out some useful functions so that they can be reused by other ethtool-netdevsim scripts. Signed-off-by: Antonio Cardace --- .../drivers/net/netdevsim/ethtool-common.sh | 69 +++ .../drivers/net/netdevsim/ethtool-pause.sh| 63 + 2 files changed, 71 ins