Re: [PATCH net-next v3 3/3] net: dp83869: Add speed optimization feature

2020-09-10 Thread Dan Murphy
Jakub On 9/8/20 12:47 PM, Jakub Kicinski wrote: On Tue, 8 Sep 2020 09:07:22 -0500 Dan Murphy wrote: On 9/5/20 1:38 PM, Jakub Kicinski wrote: On Thu, 3 Sep 2020 06:42:59 -0500 Dan Murphy wrote: +static int dp83869_set_downshift(struct phy_device *phydev, u8 cnt) +{ + int val, count; + +

Re: [PATCH net-next v3 3/3] net: dp83869: Add speed optimization feature

2020-09-08 Thread Jakub Kicinski
On Tue, 8 Sep 2020 09:07:22 -0500 Dan Murphy wrote: > On 9/5/20 1:38 PM, Jakub Kicinski wrote: > > On Thu, 3 Sep 2020 06:42:59 -0500 Dan Murphy wrote: > >> +static int dp83869_set_downshift(struct phy_device *phydev, u8 cnt) > >> +{ > >> + int val, count; > >> + > >> + if (cnt > DP83869_DOWNSHI

Re: [PATCH net-next v3 3/3] net: dp83869: Add speed optimization feature

2020-09-08 Thread Dan Murphy
Jakub On 9/5/20 1:38 PM, Jakub Kicinski wrote: On Thu, 3 Sep 2020 06:42:59 -0500 Dan Murphy wrote: +static int dp83869_set_downshift(struct phy_device *phydev, u8 cnt) +{ + int val, count; + + if (cnt > DP83869_DOWNSHIFT_8_COUNT) + return -E2BIG; ERANGE This is not

Re: [PATCH net-next v3 3/3] net: dp83869: Add speed optimization feature

2020-09-05 Thread Jakub Kicinski
On Thu, 3 Sep 2020 06:42:59 -0500 Dan Murphy wrote: > +static int dp83869_set_downshift(struct phy_device *phydev, u8 cnt) > +{ > + int val, count; > + > + if (cnt > DP83869_DOWNSHIFT_8_COUNT) > + return -E2BIG; ERANGE > + if (!cnt) > + return phy_clear_bits(ph

[PATCH net-next v3 3/3] net: dp83869: Add speed optimization feature

2020-09-03 Thread Dan Murphy
Set the speed optimization bit on the DP83869 PHY. Speed optimization, also known as link downshift, enables fallback to 100M operation after multiple consecutive failed attempts at Gigabit link establishment. Such a case could occur if cabling with only four wires (two twisted pairs) were connect