Re: [PATCH net-next v3 2/3] net: dsa: b53: Stop using dev->cpu_port incorrectly

2017-11-10 Thread Andrew Lunn
On Fri, Nov 10, 2017 at 11:33:26AM -0800, Florian Fainelli wrote: > dev->cpu_port is the driver local information that should only be used > to look up register offsets for a particular port, when they differ > (e.g: IMP port override), but it should certainly not be used in place > of the DSA conf

[PATCH net-next v3 2/3] net: dsa: b53: Stop using dev->cpu_port incorrectly

2017-11-10 Thread Florian Fainelli
dev->cpu_port is the driver local information that should only be used to look up register offsets for a particular port, when they differ (e.g: IMP port override), but it should certainly not be used in place of the DSA configured CPU port. Since the DSA switch layer calls port_vlan_{add,del}() o