Re: [PATCH net-next v3 1/2] flow dissector: ICMP support

2016-12-07 Thread Simon Horman
On Wed, Dec 07, 2016 at 11:01:48AM +0100, Jiri Pirko wrote: > Wed, Dec 07, 2016 at 10:41:36AM CET, simon.hor...@netronome.com wrote: > >Allow dissection of ICMP(V6) type and code. This should only occur > >if a packet is ICMP(V6) and the dissector has FLOW_DISSECTOR_KEY_ICMP set. > > > >There are c

Re: [PATCH net-next v3 1/2] flow dissector: ICMP support

2016-12-07 Thread Jiri Pirko
Wed, Dec 07, 2016 at 10:41:36AM CET, simon.hor...@netronome.com wrote: >Allow dissection of ICMP(V6) type and code. This should only occur >if a packet is ICMP(V6) and the dissector has FLOW_DISSECTOR_KEY_ICMP set. > >There are currently no users of FLOW_DISSECTOR_KEY_ICMP. >A follow-up patch will

[PATCH net-next v3 1/2] flow dissector: ICMP support

2016-12-07 Thread Simon Horman
Allow dissection of ICMP(V6) type and code. This should only occur if a packet is ICMP(V6) and the dissector has FLOW_DISSECTOR_KEY_ICMP set. There are currently no users of FLOW_DISSECTOR_KEY_ICMP. A follow-up patch will allow FLOW_DISSECTOR_KEY_ICMP to be used by the flower classifier. --- v3 *