Re: [PATCH net-next v3 1/2] ethtool: provide UAPI for PHY master/slave configuration.

2020-04-30 Thread Andrew Lunn
On Thu, Apr 30, 2020 at 06:37:51AM +0200, Oleksij Rempel wrote: > Hi Andrew, > > On Wed, Apr 29, 2020 at 08:16:14PM +0200, Andrew Lunn wrote: > > On Tue, Apr 28, 2020 at 09:53:07AM +0200, Oleksij Rempel wrote: > > > > Hi Oleksij > > > > Sorry for taking a while to review this. I was busy fixing

Re: [PATCH net-next v3 1/2] ethtool: provide UAPI for PHY master/slave configuration.

2020-04-30 Thread Michal Kubecek
On Thu, Apr 30, 2020 at 02:09:45PM +0200, Oleksij Rempel wrote: > > > > > @@ -119,7 +123,12 @@ static int linkmodes_fill_reply(struct sk_buff > > > > > *skb, > > > > > } > > > > > > > > > > if (nla_put_u32(skb, ETHTOOL_A_LINKMODES_SPEED, > > > > > lsettings->speed) || > > > > > -

Re: [PATCH net-next v3 1/2] ethtool: provide UAPI for PHY master/slave configuration.

2020-04-30 Thread Oleksij Rempel
Hi Michal, On Thu, Apr 30, 2020 at 10:20:20AM +0200, Michal Kubecek wrote: > On Thu, Apr 30, 2020 at 07:00:58AM +0200, Oleksij Rempel wrote: > > > > diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h > > > > index 92f737f101178..eb680e3d6bda5 100644 > > > > --- a/include/uapi

Re: [PATCH net-next v3 1/2] ethtool: provide UAPI for PHY master/slave configuration.

2020-04-30 Thread Michal Kubecek
On Thu, Apr 30, 2020 at 07:00:58AM +0200, Oleksij Rempel wrote: > > > diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h > > > index 92f737f101178..eb680e3d6bda5 100644 > > > --- a/include/uapi/linux/ethtool.h > > > +++ b/include/uapi/linux/ethtool.h > > > @@ -1666,6 +1666,31

Re: [PATCH net-next v3 1/2] ethtool: provide UAPI for PHY master/slave configuration.

2020-04-29 Thread Oleksij Rempel
Hi Michal, On Wed, Apr 29, 2020 at 09:52:22PM +0200, Michal Kubecek wrote: > On Tue, Apr 28, 2020 at 09:53:07AM +0200, Oleksij Rempel wrote: > > This UAPI is needed for BroadR-Reach 100BASE-T1 devices. Due to lack of > > auto-negotiation support, we needed to be able to configure the > > MASTER-SL

Re: [PATCH net-next v3 1/2] ethtool: provide UAPI for PHY master/slave configuration.

2020-04-29 Thread Oleksij Rempel
Hi Andrew, On Wed, Apr 29, 2020 at 08:16:14PM +0200, Andrew Lunn wrote: > On Tue, Apr 28, 2020 at 09:53:07AM +0200, Oleksij Rempel wrote: > > Hi Oleksij > > Sorry for taking a while to review this. I was busy fixing the FEC > driver which i broke :-( Not problem. Interesting, what is wrong with

Re: [PATCH net-next v3 1/2] ethtool: provide UAPI for PHY master/slave configuration.

2020-04-29 Thread Michal Kubecek
On Tue, Apr 28, 2020 at 09:53:07AM +0200, Oleksij Rempel wrote: > This UAPI is needed for BroadR-Reach 100BASE-T1 devices. Due to lack of > auto-negotiation support, we needed to be able to configure the > MASTER-SLAVE role of the port manually or from an application in user > space. > > The same

Re: [PATCH net-next v3 1/2] ethtool: provide UAPI for PHY master/slave configuration.

2020-04-29 Thread Andrew Lunn
On Tue, Apr 28, 2020 at 09:53:07AM +0200, Oleksij Rempel wrote: Hi Oleksij Sorry for taking a while to review this. I was busy fixing the FEC driver which i broke :-( > --- a/Documentation/networking/ethtool-netlink.rst > +++ b/Documentation/networking/ethtool-netlink.rst > @@ -399,6 +399,8 @@ K

[PATCH net-next v3 1/2] ethtool: provide UAPI for PHY master/slave configuration.

2020-04-28 Thread Oleksij Rempel
This UAPI is needed for BroadR-Reach 100BASE-T1 devices. Due to lack of auto-negotiation support, we needed to be able to configure the MASTER-SLAVE role of the port manually or from an application in user space. The same UAPI can be used for 1000BASE-T or MultiGBASE-T devices to force MASTER or S