Re: [PATCH net-next v3 0/6] net: qualcomm: rmnet: stop using C bit-fields

2021-03-11 Thread Alex Elder
On 3/9/21 6:27 PM, Vladimir Oltean wrote: Hi Alex, On Tue, Mar 09, 2021 at 05:39:20PM -0600, Alex Elder wrote: On 3/9/21 6:48 AM, Alex Elder wrote: Version 3 of this series uses BIT() rather than GENMASK() to define single-bit masks. It then uses a simple AND (&) operation rather than (e.g.)

Re: [PATCH net-next v3 0/6] net: qualcomm: rmnet: stop using C bit-fields

2021-03-09 Thread Vladimir Oltean
Hi Alex, On Tue, Mar 09, 2021 at 05:39:20PM -0600, Alex Elder wrote: > On 3/9/21 6:48 AM, Alex Elder wrote: > > Version 3 of this series uses BIT() rather than GENMASK() to define > > single-bit masks. It then uses a simple AND (&) operation rather > > than (e.g.) u8_get_bits() to access such fla

Re: [PATCH net-next v3 0/6] net: qualcomm: rmnet: stop using C bit-fields

2021-03-09 Thread Alex Elder
On 3/9/21 6:48 AM, Alex Elder wrote: Version 3 of this series uses BIT() rather than GENMASK() to define single-bit masks. It then uses a simple AND (&) operation rather than (e.g.) u8_get_bits() to access such flags. This was suggested by David Laight and really prefer the result. With Bjorn'

[PATCH net-next v3 0/6] net: qualcomm: rmnet: stop using C bit-fields

2021-03-09 Thread Alex Elder
Version 3 of this series uses BIT() rather than GENMASK() to define single-bit masks. It then uses a simple AND (&) operation rather than (e.g.) u8_get_bits() to access such flags. This was suggested by David Laight and really prefer the result. With Bjorn's permission I have preserved his Revie