Re: [PATCH net-next v3] virtio_net: add support for Byte Queue Limits

2024-08-14 Thread Jiri Pirko
Wed, Aug 14, 2024 at 11:17:35AM CEST, m.szyprow...@samsung.com wrote: >On 14.08.2024 09:49, Jiri Pirko wrote: >> Mon, Aug 12, 2024 at 06:55:26PM CEST, m.szyprow...@samsung.com wrote: >>> On 12.08.2024 18:47, Jiri Pirko wrote: Mon, Aug 12, 2024 at 04:57:24PM CEST, m.szyprow...@samsung.com wrote

Re: [PATCH net-next v3] virtio_net: add support for Byte Queue Limits

2024-08-14 Thread Jiri Pirko
Wed, Aug 14, 2024 at 11:43:51AM CEST, m...@redhat.com wrote: >On Wed, Aug 14, 2024 at 10:17:15AM +0200, Jiri Pirko wrote: >> >diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c >> >index 3f10c72743e9..c6af18948092 100644 >> >--- a/drivers/net/virtio_net.c >> >+++ b/drivers/net/virtio_

Re: [PATCH net-next v3] virtio_net: add support for Byte Queue Limits

2024-08-14 Thread Michael S. Tsirkin
On Wed, Aug 14, 2024 at 10:17:15AM +0200, Jiri Pirko wrote: > >diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > >index 3f10c72743e9..c6af18948092 100644 > >--- a/drivers/net/virtio_net.c > >+++ b/drivers/net/virtio_net.c > >@@ -2867,8 +2867,8 @@ static int virtnet_enable_queue_pai

Re: [PATCH net-next v3] virtio_net: add support for Byte Queue Limits

2024-08-14 Thread Marek Szyprowski
On 14.08.2024 09:49, Jiri Pirko wrote: > Mon, Aug 12, 2024 at 06:55:26PM CEST, m.szyprow...@samsung.com wrote: >> On 12.08.2024 18:47, Jiri Pirko wrote: >>> Mon, Aug 12, 2024 at 04:57:24PM CEST, m.szyprow...@samsung.com wrote: On 18.06.2024 16:44, Jiri Pirko wrote: > From: Jiri Pirko

Re: [PATCH net-next v3] virtio_net: add support for Byte Queue Limits

2024-08-14 Thread Jiri Pirko
Wed, Aug 14, 2024 at 09:49:57AM CEST, j...@resnulli.us wrote: >Mon, Aug 12, 2024 at 06:55:26PM CEST, m.szyprow...@samsung.com wrote: >>On 12.08.2024 18:47, Jiri Pirko wrote: >>> Mon, Aug 12, 2024 at 04:57:24PM CEST, m.szyprow...@samsung.com wrote: On 18.06.2024 16:44, Jiri Pirko wrote: > F

Re: [PATCH net-next v3] virtio_net: add support for Byte Queue Limits

2024-08-14 Thread Jiri Pirko
Mon, Aug 12, 2024 at 06:55:26PM CEST, m.szyprow...@samsung.com wrote: >On 12.08.2024 18:47, Jiri Pirko wrote: >> Mon, Aug 12, 2024 at 04:57:24PM CEST, m.szyprow...@samsung.com wrote: >>> On 18.06.2024 16:44, Jiri Pirko wrote: From: Jiri Pirko Add support for Byte Queue Limits (BQL).

Re: [PATCH net-next v3] virtio_net: add support for Byte Queue Limits

2024-08-12 Thread Marek Szyprowski
On 12.08.2024 18:47, Jiri Pirko wrote: > Mon, Aug 12, 2024 at 04:57:24PM CEST, m.szyprow...@samsung.com wrote: >> On 18.06.2024 16:44, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Add support for Byte Queue Limits (BQL). >>> >>> Tested on qemu emulated virtio_net device with 1, 2 and 4 queues. >

Re: [PATCH net-next v3] virtio_net: add support for Byte Queue Limits

2024-08-12 Thread Jiri Pirko
Mon, Aug 12, 2024 at 04:57:24PM CEST, m.szyprow...@samsung.com wrote: >Hi, > >On 18.06.2024 16:44, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Add support for Byte Queue Limits (BQL). >> >> Tested on qemu emulated virtio_net device with 1, 2 and 4 queues. >> Tested with fq_codel and pfifo_fast. Su

Re: [PATCH net-next v3] virtio_net: add support for Byte Queue Limits

2024-08-12 Thread Marek Szyprowski
Hi, On 18.06.2024 16:44, Jiri Pirko wrote: > From: Jiri Pirko > > Add support for Byte Queue Limits (BQL). > > Tested on qemu emulated virtio_net device with 1, 2 and 4 queues. > Tested with fq_codel and pfifo_fast. Super netperf with 50 threads is > running in background. Netperf TCP_RR results:

Re: [PATCH net-next v3] virtio_net: add support for Byte Queue Limits

2024-06-20 Thread Michael S. Tsirkin
On Wed, Jun 19, 2024 at 12:09:45PM +0200, Jiri Pirko wrote: > Wed, Jun 19, 2024 at 10:23:25AM CEST, m...@redhat.com wrote: > >On Wed, Jun 19, 2024 at 10:05:41AM +0200, Jiri Pirko wrote: > >> >Oh. Right of course. Worth a comment maybe? Just to make sure > >> >we remember not to call __free_old_xmit

Re: [PATCH net-next v3] virtio_net: add support for Byte Queue Limits

2024-06-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Tue, 18 Jun 2024 16:44:56 +0200 you wrote: > From: Jiri Pirko > > Add support for Byte Queue Limits (BQL). > > Tested on qemu emulated virtio_net device with 1, 2 and 4 queues. > Tested with fq_codel and pfifo_f

Re: [PATCH net-next v3] virtio_net: add support for Byte Queue Limits

2024-06-19 Thread Jiri Pirko
Wed, Jun 19, 2024 at 10:23:25AM CEST, m...@redhat.com wrote: >On Wed, Jun 19, 2024 at 10:05:41AM +0200, Jiri Pirko wrote: >> >Oh. Right of course. Worth a comment maybe? Just to make sure >> >we remember not to call __free_old_xmit twice in a row >> >without reinitializing stats. >> >Or move the in

Re: [PATCH net-next v3] virtio_net: add support for Byte Queue Limits

2024-06-19 Thread Michael S. Tsirkin
On Wed, Jun 19, 2024 at 10:05:41AM +0200, Jiri Pirko wrote: > >Oh. Right of course. Worth a comment maybe? Just to make sure > >we remember not to call __free_old_xmit twice in a row > >without reinitializing stats. > >Or move the initialization into __free_old_xmit to make it > >self-contained ..

Re: [PATCH net-next v3] virtio_net: add support for Byte Queue Limits

2024-06-19 Thread Michael S. Tsirkin
On Wed, Jun 19, 2024 at 10:05:41AM +0200, Jiri Pirko wrote: > Wed, Jun 19, 2024 at 09:26:22AM CEST, m...@redhat.com wrote: > >On Wed, Jun 19, 2024 at 07:45:16AM +0200, Jiri Pirko wrote: > >> Tue, Jun 18, 2024 at 08:18:12PM CEST, m...@redhat.com wrote: > >> >This looks like a sensible way to do this

Re: [PATCH net-next v3] virtio_net: add support for Byte Queue Limits

2024-06-19 Thread Jiri Pirko
Wed, Jun 19, 2024 at 09:26:22AM CEST, m...@redhat.com wrote: >On Wed, Jun 19, 2024 at 07:45:16AM +0200, Jiri Pirko wrote: >> Tue, Jun 18, 2024 at 08:18:12PM CEST, m...@redhat.com wrote: >> >This looks like a sensible way to do this. >> >Yet something to improve: >> > >> > >> >On Tue, Jun 18, 2024 a

Re: [PATCH net-next v3] virtio_net: add support for Byte Queue Limits

2024-06-19 Thread Michael S. Tsirkin
On Wed, Jun 19, 2024 at 07:45:16AM +0200, Jiri Pirko wrote: > Tue, Jun 18, 2024 at 08:18:12PM CEST, m...@redhat.com wrote: > >This looks like a sensible way to do this. > >Yet something to improve: > > > > > >On Tue, Jun 18, 2024 at 04:44:56PM +0200, Jiri Pirko wrote: > >> From: Jiri Pirko > >> >

Re: [PATCH net-next v3] virtio_net: add support for Byte Queue Limits

2024-06-18 Thread Jiri Pirko
Tue, Jun 18, 2024 at 08:18:12PM CEST, m...@redhat.com wrote: >This looks like a sensible way to do this. >Yet something to improve: > > >On Tue, Jun 18, 2024 at 04:44:56PM +0200, Jiri Pirko wrote: >> From: Jiri Pirko >> [...] >> +static void __free_old_xmit(struct send_queue *sq, struct netdev

Re: [PATCH net-next v3] virtio_net: add support for Byte Queue Limits

2024-06-18 Thread Michael S. Tsirkin
This looks like a sensible way to do this. Yet something to improve: On Tue, Jun 18, 2024 at 04:44:56PM +0200, Jiri Pirko wrote: > From: Jiri Pirko > > Add support for Byte Queue Limits (BQL). > > Tested on qemu emulated virtio_net device with 1, 2 and 4 queues. > Tested with fq_codel and pfif

[PATCH net-next v3] virtio_net: add support for Byte Queue Limits

2024-06-18 Thread Jiri Pirko
From: Jiri Pirko Add support for Byte Queue Limits (BQL). Tested on qemu emulated virtio_net device with 1, 2 and 4 queues. Tested with fq_codel and pfifo_fast. Super netperf with 50 threads is running in background. Netperf TCP_RR results: NOBQL FQC 1q: 159.56 159.33 158.50 154.31agv: