Re: [PATCH net-next v3] packet: uses kfree_skb() for errors.

2016-04-14 Thread Weongyo Jeong
On Wed, Apr 13, 2016 at 10:56:01PM -0400, David Miller wrote: > From: Weongyo Jeong > Date: Fri, 8 Apr 2016 09:25:48 -0700 > > > diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c > > index 1ecfa71..4e054bb 100644 > > --- a/net/packet/af_packet.c > > +++ b/net/packet/af_packet.c > > @@

Re: [PATCH net-next v3] packet: uses kfree_skb() for errors.

2016-04-13 Thread David Miller
From: Weongyo Jeong Date: Fri, 8 Apr 2016 09:25:48 -0700 > diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c > index 1ecfa71..4e054bb 100644 > --- a/net/packet/af_packet.c > +++ b/net/packet/af_packet.c > @@ -2042,6 +2042,7 @@ static int packet_rcv(struct sk_buff *skb, struct > net_d

[PATCH net-next v3] packet: uses kfree_skb() for errors.

2016-04-08 Thread Weongyo Jeong
consume_skb() isn't for error cases that kfree_skb() is more proper one. At this patch, it fixed tpacket_rcv() and packet_rcv() to be consistent for error or non-error cases letting perf trace its event properly. Signed-off-by: Weongyo Jeong --- net/packet/af_packet.c | 14 -- 1 fil