Re: [PATCH net-next v2 7/8] net: phy: meson-gxl: add interrupt support

2017-12-07 Thread Andrew Lunn
> The phy being internal, I think it is unlikely to ever share its interrupt > though. O.K, don't bother. > Thanks for the lightning fast review by the way ! You are welcome. Andrew

Re: [PATCH net-next v2 7/8] net: phy: meson-gxl: add interrupt support

2017-12-07 Thread Jerome Brunet
On Thu, 2017-12-07 at 16:54 +0100, Andrew Lunn wrote: > On Thu, Dec 07, 2017 at 03:27:14PM +0100, Jerome Brunet wrote: > > Enable interrupt support in meson-gxl PHY driver > > Hi Jerome > > Is it possible to implement did_interrupt()? That allows for shared > interrupts. It does however work fine

Re: [PATCH net-next v2 7/8] net: phy: meson-gxl: add interrupt support

2017-12-07 Thread Andrew Lunn
On Thu, Dec 07, 2017 at 03:27:14PM +0100, Jerome Brunet wrote: > Enable interrupt support in meson-gxl PHY driver Hi Jerome Is it possible to implement did_interrupt()? That allows for shared interrupts. It does however work fine without it, so long as the interrupt is not shared. Than

[PATCH net-next v2 7/8] net: phy: meson-gxl: add interrupt support

2017-12-07 Thread Jerome Brunet
Enable interrupt support in meson-gxl PHY driver Signed-off-by: Jerome Brunet --- drivers/net/phy/meson-gxl.c | 37 - 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c index 5325940fe899..86