Re: [PATCH net-next v2 7/7] ethtool: add compat for devlink info

2019-01-31 Thread kbuild test robot
Hi Jakub, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Jakub-Kicinski/devlink-add-device-driver-information-API/20190131-21 config: m68k-sun3_defconfig (attached as .config) compiler: m68k-linux-gnu-

Re: [PATCH net-next v2 7/7] ethtool: add compat for devlink info

2019-01-31 Thread kbuild test robot
Hi Jakub, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Jakub-Kicinski/devlink-add-device-driver-information-API/20190131-21 config: i386-randconfig-n0-01300126 (attached as .config) compiler: gcc-8 (

Re: [PATCH net-next v2 7/7] ethtool: add compat for devlink info

2019-01-30 Thread Jiri Pirko
Wed, Jan 30, 2019 at 08:05:13PM CET, jakub.kicin...@netronome.com wrote: >If driver did not fill the fw_version field, try to call into >the new devlink get_info op and collect the versions that way. >We assume ethtool was always reporting running versions. > >Signed-off-by: Jakub Kicinski >--- >

[PATCH net-next v2 7/7] ethtool: add compat for devlink info

2019-01-30 Thread Jakub Kicinski
If driver did not fill the fw_version field, try to call into the new devlink get_info op and collect the versions that way. We assume ethtool was always reporting running versions. Signed-off-by: Jakub Kicinski --- include/net/devlink.h | 7 ++ net/core/devlink.c| 52 ++