RE: [PATCH net-next v2 6/6] enetc: Add adaptive interrupt coalescing

2020-07-21 Thread Claudiu Manoil
>-Original Message- >From: Claudiu Manoil >Sent: Saturday, July 18, 2020 8:20 PM [...] >Subject: Re: [PATCH net-next v2 6/6] enetc: Add adaptive interrupt coalescing > > >On 17.07.2020 22:30, Jakub Kicinski wrote: >> On Fri, 17 Jul 2020 18:37:04 +0300 Claud

Re: [PATCH net-next v2 6/6] enetc: Add adaptive interrupt coalescing

2020-07-18 Thread Claudiu Manoil
On 17.07.2020 22:30, Jakub Kicinski wrote: On Fri, 17 Jul 2020 18:37:04 +0300 Claudiu Manoil wrote: + if (tx_ictt == ENETC_TXIC_TIMETHR) + ic_mode |= ENETC_IC_TX_OPTIMAL; Doesn't seem you ever read/check the ENETC_IC_TX_OPTIMAL flag? It's used implicitly though ;), as

Re: [PATCH net-next v2 6/6] enetc: Add adaptive interrupt coalescing

2020-07-17 Thread Jakub Kicinski
On Fri, 17 Jul 2020 18:37:04 +0300 Claudiu Manoil wrote: > + if (tx_ictt == ENETC_TXIC_TIMETHR) > + ic_mode |= ENETC_IC_TX_OPTIMAL; Doesn't seem you ever read/check the ENETC_IC_TX_OPTIMAL flag?

[PATCH net-next v2 6/6] enetc: Add adaptive interrupt coalescing

2020-07-17 Thread Claudiu Manoil
Use the generic dynamic interrupt moderation (DIM) framework to implement adaptive interrupt coalescing on Rx. With the per-packet interrupt scheme, a high interrupt rate has been noted for moderate traffic flows leading to high CPU utilization. The DIM scheme implemented by the current patch add