Re: [PATCH net-next v2 3/9] ethtool: add a new command for reading standard stats

2021-04-19 Thread Jakub Kicinski
On Sat, 17 Apr 2021 22:10:39 +0200 Michal Kubecek wrote: > On Sat, Apr 17, 2021 at 12:18:08PM -0700, Jakub Kicinski wrote: > > Heh, I misunderstood your question. You're asking if the strings can be > > queried from the command line. > > > > No, I don't think so. We could add some form of "porcela

Re: [PATCH net-next v2 3/9] ethtool: add a new command for reading standard stats

2021-04-18 Thread Ido Schimmel
On Fri, Apr 16, 2021 at 12:27:39PM -0700, Jakub Kicinski wrote: > +static int stats_prepare_data(const struct ethnl_req_info *req_base, > + struct ethnl_reply_data *reply_base, > + struct genl_info *info) > +{ > + const struct stats_req_info *

Re: [PATCH net-next v2 3/9] ethtool: add a new command for reading standard stats

2021-04-17 Thread Michal Kubecek
On Sat, Apr 17, 2021 at 12:18:08PM -0700, Jakub Kicinski wrote: > On Sat, 17 Apr 2021 12:15:20 -0700 Jakub Kicinski wrote: > > On Sat, 17 Apr 2021 21:53:40 +0300 Ido Schimmel wrote: > > > On Sat, Apr 17, 2021 at 11:13:51AM -0700, Jakub Kicinski wrote: > > > > On Sat, 17 Apr 2021 10:57:42 -0700 Ja

Re: [PATCH net-next v2 3/9] ethtool: add a new command for reading standard stats

2021-04-17 Thread Ido Schimmel
On Sat, Apr 17, 2021 at 12:18:08PM -0700, Jakub Kicinski wrote: > On Sat, 17 Apr 2021 12:15:20 -0700 Jakub Kicinski wrote: > > On Sat, 17 Apr 2021 21:53:40 +0300 Ido Schimmel wrote: > > > On Sat, Apr 17, 2021 at 11:13:51AM -0700, Jakub Kicinski wrote: > > > > On Sat, 17 Apr 2021 10:57:42 -0700 Ja

Re: [PATCH net-next v2 3/9] ethtool: add a new command for reading standard stats

2021-04-17 Thread Jakub Kicinski
On Sat, 17 Apr 2021 12:15:20 -0700 Jakub Kicinski wrote: > On Sat, 17 Apr 2021 21:53:40 +0300 Ido Schimmel wrote: > > On Sat, Apr 17, 2021 at 11:13:51AM -0700, Jakub Kicinski wrote: > > > On Sat, 17 Apr 2021 10:57:42 -0700 Jakub Kicinski wrote: > > > > > > FWIW ethnl_parse_bit() -> ETHTOOL_A_

Re: [PATCH net-next v2 3/9] ethtool: add a new command for reading standard stats

2021-04-17 Thread Jakub Kicinski
On Sat, 17 Apr 2021 21:53:40 +0300 Ido Schimmel wrote: > On Sat, Apr 17, 2021 at 11:13:51AM -0700, Jakub Kicinski wrote: > > On Sat, 17 Apr 2021 10:57:42 -0700 Jakub Kicinski wrote: > > > Um, yes and now. The only places the user space puts those names > > > is the help message and man page. > >

Re: [PATCH net-next v2 3/9] ethtool: add a new command for reading standard stats

2021-04-17 Thread Ido Schimmel
On Sat, Apr 17, 2021 at 11:13:51AM -0700, Jakub Kicinski wrote: > On Sat, 17 Apr 2021 10:57:42 -0700 Jakub Kicinski wrote: > > > I tried to understand how you add new groups without user space > > > changes and I think this statement is not entirely accurate. > > > > > > At minimum, user space nee

Re: [PATCH net-next v2 3/9] ethtool: add a new command for reading standard stats

2021-04-17 Thread Jakub Kicinski
On Sat, 17 Apr 2021 10:57:42 -0700 Jakub Kicinski wrote: > > I tried to understand how you add new groups without user space > > changes and I think this statement is not entirely accurate. > > > > At minimum, user space needs to know the names of these groups, but > > currently there is no way to

Re: [PATCH net-next v2 3/9] ethtool: add a new command for reading standard stats

2021-04-17 Thread Jakub Kicinski
On Sat, 17 Apr 2021 20:15:11 +0300 Ido Schimmel wrote: > On Fri, Apr 16, 2021 at 12:27:39PM -0700, Jakub Kicinski wrote: > > Add an interface for reading standard stats, including > > stats which don't have a corresponding control interface. > > > > Start with IEEE 802.3 PHY stats. There seems to

Re: [PATCH net-next v2 3/9] ethtool: add a new command for reading standard stats

2021-04-17 Thread Ido Schimmel
On Fri, Apr 16, 2021 at 12:27:39PM -0700, Jakub Kicinski wrote: > Add an interface for reading standard stats, including > stats which don't have a corresponding control interface. > > Start with IEEE 802.3 PHY stats. There seems to be only > one stat to expose there. > > Define API to not requir

[PATCH net-next v2 3/9] ethtool: add a new command for reading standard stats

2021-04-16 Thread Jakub Kicinski
Add an interface for reading standard stats, including stats which don't have a corresponding control interface. Start with IEEE 802.3 PHY stats. There seems to be only one stat to expose there. Define API to not require user space changes when new stats or groups are added. Groups are based on b