Re: [PATCH net-next v2 3/6] rtnetlink: add helper to dump qdisc name

2017-09-23 Thread Florian Westphal
Eric Dumazet wrote: > On Fri, 2017-09-22 at 08:10 +0200, Florian Westphal wrote: > > We can use rcu here to make this safe even if we would not hold rtnl: > > qdisc_destroy uses call_rcu to free the Qdisc struct. > > > Where do you see call_rcu() called from qdisc_destroy() ? > > You missed thi

Re: [PATCH net-next v2 3/6] rtnetlink: add helper to dump qdisc name

2017-09-23 Thread Eric Dumazet
On Fri, 2017-09-22 at 08:10 +0200, Florian Westphal wrote: > We can use rcu here to make this safe even if we would not hold rtnl: > qdisc_destroy uses call_rcu to free the Qdisc struct. Where do you see call_rcu() called from qdisc_destroy() ? You missed this commit I guess 752fbcc33405d6f8249

Re: [PATCH net-next v2 3/6] rtnetlink: add helper to dump qdisc name

2017-09-23 Thread David Ahern
On 9/22/17 12:10 AM, Florian Westphal wrote: > We can use rcu here to make this safe even if we would not hold rtnl: > qdisc_destroy uses call_rcu to free the Qdisc struct. > > Signed-off-by: Florian Westphal > --- > net/core/rtnetlink.c | 16 ++-- > 1 file changed, 14 insertions(+),

[PATCH net-next v2 3/6] rtnetlink: add helper to dump qdisc name

2017-09-21 Thread Florian Westphal
We can use rcu here to make this safe even if we would not hold rtnl: qdisc_destroy uses call_rcu to free the Qdisc struct. Signed-off-by: Florian Westphal --- net/core/rtnetlink.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/net/core/rtnetlink.c b/net/co